Set project start date to now and add field in create project form to set the end date#4495
Conversation
|
@sandeepsajan0 Can you see why the create project test is failing? Likely something obvious but I can't see it. |
frjo
added
Type: Enhancement
| model = Project | ||
| orderable = True | ||
| order_by = ("-created_at",) | ||
| order_by = ("-end_date",) |
There was a problem hiding this comment.
| order_by = ("-end_date",) | |
| order_by = ("end_date",) |
I think in their current spreadsheet staff sort by the ascending end dates so this may be a bit closer to that
| {% if request.user.is_apply_staff %} | ||
| <a class="transition-opacity hover:opacity-70 is-active" | ||
| href="{% url 'apply:projects:project_dates_update' object.submission.id %}" | ||
| hx-get="{% url 'apply:projects:project_dates_update' object.submission.id %}" | ||
| hx-target="#htmx-modal" | ||
| > | ||
| {% heroicon_solid "pencil-square" class="inline mt-2 ms-1" aria_hidden=true %} | ||
| <span class="sr-only">{% trans "edit dates" %}</span> | ||
| </a> | ||
| {% endif %} |
There was a problem hiding this comment.
should we also put this button on the start date? even though it opens the same modal it might be more intuitive if they wanted to open the start date
|
|
||
| <div class="p-4"> | ||
| {% include 'includes/dialog_form_base.html' with form=form value=value %} | ||
| </div> |
There was a problem hiding this comment.
Not an important detail at all but the date pickers are different widths - not sure if this can be fixed here because of the include template though
There was a problem hiding this comment.
There was custom css to change the width of the last date field, been there for years.
Removed it and we will see if it mess something up, likely not.
|
worked really well! a few small comments/thoughts but it should be ready to go! |
frjo
force-pushed
the
enhancement/project_start_end_updates
branch
from
aafccc9 to
d61b8a1
Compare
|
@wes-otf Good changes I believe. I implemented them and deployed to test. |
|
seems to work great! I think this is exactly what they were asking for, I'll tag this for user testing to confirm if that's cool with you |
frjo
removed
Status: Needs testing
|
Test fails because they compare date with time and date without time. |
… set the end date. Show dates on project detail view.
…x width. Revers project list order.
frjo
force-pushed
the
enhancement/project_start_end_updates
branch
from
9ace482 to
424039e
Compare
|
Rebased after report app refractor. |
|
@frjo I have a few more small tweaks coming based on a some of my code changes, might add a few more unit tests too |
frjo
added
Status: Needs testing
… informative for when `PROJECTS_START_AFTER_CONTRACTING` is enabled
|
I added an error message for the end date being before the start date in the modal along with some info regarding when the start date will be set if |
frjo
removed
Status: Needs testing
2 participants
Fixes #4494