Fix preview & submit button on application form#4510
Merged
Conversation
If the submit button is disabled before submit event is processed by the borwser, the name/value on the button is not included in the form value. This PR fixes that by using setTimeout. There are other minor updates to js, e.g. iterating on submit buttons instead of processing only the first submit button. Some formatting update html is also there - helps keep html readiable and for better git diff in future.
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue with the "Preview and Submit" button by ensuring that its name/value is included in the form submission. Key changes include:
- Replacing the single submit button selection with iterating over all submit buttons.
- Introducing a setTimeout with 0 delay to schedule the disabling of buttons.
- Adding the passive option to event listeners and minor HTML formatting updates.
Files not reviewed (1)
- hypha/apply/funds/templates/funds/application_base.html: Language not supported
theskumar
commented
Apr 19, 2025
| button.textContent = "Submitting..."; | ||
| } | ||
| }); | ||
| }, 0); |
Member
Author
There was a problem hiding this comment.
This is the primary fix for form not sending the preview key/value.
theskumar
commented
Apr 19, 2025
| // 3. tab or enter key pressed | ||
| document.body.addEventListener("mousemove", unlockApplicationForm, { | ||
| once: true, | ||
| passive: true, |
theskumar
added
Type: Patch
frjo
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the submit button is disabled before submit event is processed by the borwser, the name/value on the button is not included in the form value.
This PR fixes that by using
setTimeout.There are other minor updates to js, e.g. iterating on submit buttons instead of processing only the first submit button.
Some formatting update html is also there - helps keep html readiable and for better git diff in future.
Fixes #4497
Test Steps