Apply the docs-only ignore to the example lane groups - #2101
Merged
Conversation
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe workflows now use recursive glob patterns for ignored documentation, image, and notebook files. The example-test workflow applies these exclusions to the shared and individual test lanes. ChangesFile-ignore gating
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2101 +/- ##
==========================================
- Coverage 78.60% 77.57% -1.04%
==========================================
Files 522 522
Lines 60167 60167
==========================================
- Hits 47294 46673 -621
- Misses 12873 13494 +621
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The ignore never took effect. Two separate causes, both found by a probe PR against merged main whose only change was a README: - files_ignore does not apply to files_yaml groups, so the example lanes filtered nothing. Exclude per group instead. - As an inline negation, `**.md` does not exclude, while `**/*.md` does (micromatch treats the two forms differently, though isMatch accepts both). This also made _pr_gate's ignore inert for its callers, where it only looked correct because docs paths usually fall outside the watch lists. Verified against micromatch 4.0.5, the version the action depends on: README.md, examples/diffusers/README.md and a nested .png now match no lane, while config.py -> onnx, examples/dataset -> torch+trtllm and tests/examples/conftest.py -> common are unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com>
kevalmorabia97
force-pushed
the
kmorabia/ci-fix-files-ignore-yaml
branch
from
August 7, 2026 08:15
14f1406 to
f1a3e49
Compare
Contributor
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Contributor
|
This was referenced Aug 7, 2026
kevalmorabia97
added a commit
that referenced
this pull request
Aug 7, 2026
### What does this PR do? Type of change: CI/CD maintenance Last of the [Node 20](https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/) actions: `step-security/changed-files` v46.0.5 → v47.0.5, in `_pr_gate.yml`, `example_tests.yml` and `unit_tests.yml`. Deliberately separate from #2102. Every gate in the repo runs through this action, and the example lanes depend on its `files_yaml` per-group outputs plus `any_modified` semantics. v47 has no release notes describing output behavior, and the upstream v47 notes are dependency bumps only — so this is the one bump I could not clear from a changelog. On its own, any gating regression is unambiguous. What I did verify at `v47.0.5`: - `micromatch` is still `^4.0.5` — the matcher the lane patterns were validated against - `files`, `files_ignore`, `files_yaml`, `files_ignore_yaml` are all still inputs - `any_modified`, `any_changed`, `changed_keys` are all still documented outputs ### Testing Static checks above. The behavior that matters cannot be proven from this PR: it changes workflow files, which are in the `common` group, so **every lane runs regardless** of whether gating still works. I plan to confirm with a throwaway probe PR against this branch — a docs-only change must run nothing, and a single-example change must run exactly one lane — the same method that caught the two ignore bugs fixed in #2101. ### Before your PR is "*Ready for review*" - Is this change backward compatible?: ✅ - If you copied code from any other sources or added a new PIP dependency, did you follow guidance in `CONTRIBUTING.md`: N/A - Did you write any new necessary tests?: N/A — CI configuration - Did you update [Changelog](https://github.com/NVIDIA/Model-Optimizer/blob/main/CHANGELOG.rst)?: N/A - Did you get Claude approval on this PR?: ❌ — not yet run <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Chores** * Updated pull-request file-change checks to use the latest available file-detection action. * Applied the update consistently across example-test and unit-test workflows. * Improved consistency and reliability across automated pull-request validation checks without changing application behavior. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Type of change: Bug fix (CI)
Follow-up to #2090.
files_ignoredoes not apply tofiles_yamlgroups — the action keys ignores separately throughfiles_ignore_yaml. Docs-only PRs therefore still matched a lane: a change toexamples/diffusers/README.mdalone started the onnx lane's three GPU jobs.Only
example_tests.ymlis affected.gpu_tests,regression_testsandunit_testsgo through_pr_gate.yml, which uses the plainfiles+files_ignorepair where the ignore does apply.Testing
Found by a probe PR opened against merged main (a README-only change), which showed
onnxrunning when nothing should have. The same probe is re-run against this branch to confirm the fix — see the linked draft PR.Before your PR is "Ready for review"
CONTRIBUTING.md: N/ASummary by CodeRabbit