cleanup: sweep stale overrides/ refs + remove orphaned values-production.yaml (post-#84)#86
Conversation
Follow-up to shingonoide's review on #84: with deployment/.../overrides/ removed (moved to gitops), sweep the now-stale references so no one looks for the deleted directory: - AGENTS.md: drop the overrides/ bullet; note overrides live in the gitops repo. - values.yaml comments (gpuNodeSelector, valkey.enabled, externalValkey): point at the gitops overrides instead of overrides/<env>.yaml. Not touching values-production.yaml here — it carries config NOT present in the gitops production override (affinity, security contexts, valkey persistence/resources, ...), so its removal needs a migrate-or-confirm-dead decision, tracked separately.
Completes shingonoide's #84 cleanup ask. This standalone 'sample production values' file predates the ArgoCD/gitops overrides pattern and is referenced by nothing (no appset, CI, Makefile, or docs) — so it deploys nowhere. Verified every production-relevant key is already covered by the chart defaults + the gitops overrides/production.yaml (telemetry, resources, security contexts; prod uses external valkey so the bundled-valkey config is moot). The only key unique to this file — affinity.podAntiAffinity — is a no-op at the effective replicaCount of 1; if prod ever scales to 2+ replicas, add anti-affinity to the gitops override then. Also keeps Plainsight-internal prod config (otel-collector host, plainsightai image) out of this OSS repo.
lucasmundim
changed the title
leandrobmarinho
left a comment
leandrobmarinho
left a comment
There was a problem hiding this comment.
Review
Summary: Post-#84 cleanup — repoints stale overrides/ references in AGENTS.md and values.yaml comments to the gitops repo, and deletes the orphaned values-production.yaml sample.
Looks good. No blocking issues found. Verified the deletion is safe: a full-tree scan finds no reference to values-production anywhere (no appset / CI / Makefile / Helm / docs), so it deploys nowhere and removing it breaks nothing. The values.yaml diff is comment-only — the actual values (gpuNodeSelector, valkey.enabled, externalValkey.enabled) are unchanged — so there is no behavior change, and the podAntiAffinity key it carried is a no-op at the effective replicaCount: 1 (correctly noted as a gitops add-back if prod ever scales to 2+). Also good hygiene to pull Plainsight-internal prod config (otel host, plainsightai image) out of this OSS repo now that the real per-env config lives in gitops.
shingonoide
left a comment
shingonoide
left a comment
There was a problem hiding this comment.
Confirmed this is a clean post-#84 cleanup. The deleted values-production.yaml was an unconsumed sample: nothing in the repo references it (no template, workflow, Makefile, or manifest), and helm template renders correctly from values.yaml alone. The AGENTS.md and values.yaml edits correctly repoint the stale overrides/ references to the gitops repo. LGTM.
3 participants
Completes shingonoide's follow-up ask on #84 — with
deployment/openfilter-pipelines-controller/overrides/moved to gitops:1. Sweep stale
overrides/referencesoverrides/bullet; thevalues.yamlbullet now notes per-env overrides live in thegitopsrepo.gpuNodeSelector/valkey.enabled/externalValkey): point at the gitops overrides instead ofoverrides/<env>.yaml.2. Remove orphaned
values-production.yamlA standalone 'sample production values' file that predates the ArgoCD/gitops pattern and is referenced by nothing (no appset/CI/Makefile/docs → deploys nowhere). Verified safe to delete — diffed every key against the chart defaults + gitops
overrides/production.yaml:valkey.enabled: falsein gitops) ✅affinity.podAntiAffinity(only key unique to this file)replicaCount: 1; add to gitops if prod ever scales to 2+Also removes Plainsight-internal prod config (otel-collector host,
plainsightaiimage) from this OSS repo.helm lintclean.