Skip to content

cleanup: sweep stale overrides/ refs + remove orphaned values-production.yaml (post-#84) #86

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lucasmundim merged 2 commits into from
Jul 10, 2026
+5 −100
Merged

cleanup: sweep stale overrides/ refs + remove orphaned values-production.yaml (post-#84) #86

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed3b1a1
docs: point overrides references at the gitops repo (post-#84)
lucasmundim Jul 9, 2026
f7ff64b
chart: remove orphaned values-production.yaml
lucasmundim Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,7 @@ cd deployment/openfilter-pipelines-controller && helm dependency update
- `deployment/openfilter-pipelines-controller/`: Main Helm chart
- `deployment/openfilter-pipelines-controller/crds/`: CRD manifests (synced from config/crd/bases)
- `deployment/openfilter-pipelines-controller/templates/`: Kubernetes resource templates
- `deployment/openfilter-pipelines-controller/overrides/`: Per-environment value overrides (development, lab, staging, production)
- `deployment/openfilter-pipelines-controller/values.yaml`: Default configuration values
- `deployment/openfilter-pipelines-controller/values.yaml`: Default configuration values (per-environment overrides live in the private `gitops` repo, not here)

- **hack/**: Utility scripts
- `hack/update-helm-crds.sh`: Script to sync CRDs from config/crd/bases to Helm chart
Expand Down
95 changes: 0 additions & 95 deletions deployment/openfilter-pipelines-controller/values-production.yaml
View file
Open in desktop

This file was deleted.

7 changes: 4 additions & 3 deletions deployment/openfilter-pipelines-controller/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,8 @@ volumeMounts: []
# GPU node selector: comma-separated key=value pairs applied to pods that request
# nvidia.com/gpu resources (e.g. "cloud.google.com/gke-gpu-driver-version=latest").
# Leave empty to disable (no node selector is applied). The GKE-specific value is
# set per environment in overrides/<env>.yaml, so the chart installs cleanly on
# set per environment in the gitops repo (controllers/openfilter-pipelines-controller/
# overrides/<env>.yaml), so the chart installs cleanly on
# non-GKE clusters (kind, minikube, EKS, bare metal) out of the box.
gpuNodeSelector: ""

Expand Down Expand Up @@ -200,7 +201,7 @@ args: []
valkey:
# Enable the bundled Valkey subchart so the chart self-installs out of the box.
# Environments that connect to a cluster-managed Valkey flip this to false and
# enable externalValkey below — see overrides/<env>.yaml.
# enable externalValkey below — see the gitops repo overrides.
enabled: true

# Valkey architecture (standalone or replication)
Expand Down Expand Up @@ -242,7 +243,7 @@ valkey:
# External Valkey configuration
# Use this to connect to an existing Valkey instance instead of deploying one.
# Disabled by default; the cluster-managed host + auth Secret are environment-
# specific and live in overrides/<env>.yaml, not in the chart defaults.
# specific and live in the gitops repo overrides, not in the chart defaults.
externalValkey:
enabled: false
host: ""
Expand Down