Open
Conversation
…5/Hardware into feature/add-bringup
zbrotherton
requested changes
Mar 12, 2026
zbrotherton
left a comment
zbrotherton
left a comment
There was a problem hiding this comment.
I need to look into this deeper, but at first glance it looks like you're deleting vital launch components
Pull from develop so we're sure I'm only looking at your changes?
| Node = [ | ||
| ] | ||
|
|
||
| return LaunchDescription(declared_arguments + Node) |
There was a problem hiding this comment.
This won't work. We need nav2 to be part of our launch description, otherwise this launch file will not function
There was a problem hiding this comment.
You added the description to our arguments? I'm confused
Comment on lines
27
to
32
| nav2 = IncludeLaunchDescription( | ||
| PythonLaunchDescriptionSource(nav2_launch_path), | ||
| launch_arguments={ | ||
| 'params_file' : config_path | ||
| }.items() | ||
| ) |
There was a problem hiding this comment.
Remove all commented out code blocks - this goes against the point of using git
Comment on lines
-16
to
-25
| declared_arguments.append( | ||
| DeclareLaunchArgument( | ||
| name="use_sim", | ||
| default_value="false", | ||
| description="Wether or not the robot is launching in simulation" | ||
| ) | ||
| ) | ||
|
|
||
| use_sim = LaunchConfiguration("use_sim") | ||
|
|
There was a problem hiding this comment.
Confused why you're removing these.
Comment on lines
+63
to
+66
| #TODO | ||
| linear.x.has_jerk_limits: false | ||
| linear.x.max_jerk: 0.0 | ||
| linear.x.min_jerk: 0.0 | ||
| # #TODO | ||
| # linear.x.has_jerk_limits: false | ||
| # linear.x.max_jerk: 0.0 | ||
| # linear.x.min_jerk: 0.0 |
Author
There was a problem hiding this comment.
i didn't do that though ;(
added 5 commits
March 20, 2026 21:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.