Put the linear calculator behind an interface for easier swapping.#175
Merged
shishghate merged 5 commits intomainfrom Mar 26, 2026
Merged
Put the linear calculator behind an interface for easier swapping.#175shishghate merged 5 commits intomainfrom
shishghate merged 5 commits intomainfrom
Conversation
Code Coverage Report
|
| this.launchVelocityRPS = launchVelocityRPS; | ||
| } | ||
|
|
||
| public double getInclineAngelDegrees() { |
Contributor
There was a problem hiding this comment.
Angle is spelled wrong.
Contributor
There was a problem hiding this comment.
Why not just make this a record?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved the shooter angle and speed calculation behind an interface and refactored it.
Please take a look and keep this in mind when implementing your solutions. We can change the signature of the call if needed.