Skip to content

Small finishing touches added to explore_bag_data.ipynb file#859

Merged
raghumanimehta merged 32 commits intomainfrom
SPDonaghy/753-pathfinding-data-plotting
Apr 2, 2026
Merged

Small finishing touches added to explore_bag_data.ipynb file#859
raghumanimehta merged 32 commits intomainfrom
SPDonaghy/753-pathfinding-data-plotting

Conversation

@ethanhu912
Copy link
Copy Markdown
Contributor

Description

  • Resolves Pathfinding data plotting workflow #753
  • Made some small changes to explore_bag_data.ipynb
  • Created a helper functions cell and moved all repeated functions to that cell
  • Removed the code that opened the same database in each cell (so it's only opened once at the start)
  • Standardized all calculations to units in kilometers and seconds

Verification

  • Ran each code cell to ensure the same functionality as before
  • Verified that the cell returned values in km/h

SPDonaghy and others added 30 commits January 17, 2026 23:06
…ocal_path to test whether the automatic data collection works.
…signature, added toggle launch argument 'record' to start data collection process, changed target directory path to use environment variable
…into SPDonaghy/753-pathfinding-data-plotting
…into SPDonaghy/753-pathfinding-data-plotting
@ethanhu912 ethanhu912 requested a review from AMaharaj16 March 14, 2026 03:43
@ethanhu912 ethanhu912 self-assigned this Mar 14, 2026
@ethanhu912 ethanhu912 added the path Pathfinding team label Mar 14, 2026
@SPDonaghy
Copy link
Copy Markdown
Contributor

Hi Ethan! Sorry cant really review this properly as the diff for an ipynb file is practically unreadable. If everything looks good/works for you we can merge this. The notebook can just serve as a good place to test things out but I wont look at the code in them too closely. We can review the code for the actual script (that presumably does the things the cells in the nb do) a bit more closely once that's ready.

@raghumanimehta raghumanimehta merged commit 511eefb into main Apr 2, 2026
6 checks passed
@raghumanimehta raghumanimehta deleted the SPDonaghy/753-pathfinding-data-plotting branch April 2, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

path Pathfinding team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pathfinding data plotting workflow

3 participants