Small finishing touches added to explore_bag_data.ipynb file#859
Merged
raghumanimehta merged 32 commits intomainfrom Apr 2, 2026
Merged
Small finishing touches added to explore_bag_data.ipynb file#859raghumanimehta merged 32 commits intomainfrom
raghumanimehta merged 32 commits intomainfrom
Conversation
…ocal_path to test whether the automatic data collection works.
…signature, added toggle launch argument 'record' to start data collection process, changed target directory path to use environment variable
…into SPDonaghy/753-pathfinding-data-plotting
…hub.com/UBCSailbot/sailbot_workspace into SPDonaghy/753-pathfinding-data-plotting
…f the rosbag script
… calculations to helper functions cell
…into SPDonaghy/753-pathfinding-data-plotting
…hub.com/UBCSailbot/sailbot_workspace into SPDonaghy/753-pathfinding-data-plotting
Contributor
|
Hi Ethan! Sorry cant really review this properly as the diff for an ipynb file is practically unreadable. If everything looks good/works for you we can merge this. The notebook can just serve as a good place to test things out but I wont look at the code in them too closely. We can review the code for the actual script (that presumably does the things the cells in the nb do) a bit more closely once that's ready. |
SPDonaghy
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
explore_bag_data.ipynbVerification