fix: preserve tabs after document read errors - #293
Open
PathGao wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
@alecdotdev This addresses the tab-closing path observed around transient file replacement. It is ready after #286. |
This was referenced Jul 31, 2026
PathGao
force-pushed
the
fix/preserve-tabs-on-read-error
branch
from
July 31, 2026 05:50
e3bdb7f to
6947e98
Compare
Contributor
Author
This was referenced Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #292
Keep the tab, its in-memory buffer, and the recent-file entry when a document read fails. A transient missing-file event during an external atomic replacement can no longer close a recoverable document.
Depends on #288. Please merge in this order: #286 → #287 → #288 → this PR.
Validation: