chore: ungate web-search commands#1558
Merged
Merged
Conversation
agentcore-devx-automation
Bot
added
the
claude-security-reviewing
github-actions
Bot
added
the
agentcore-harness-reviewing
Contributor
Package TarballHow to installgh release download pr-1558-tarball --repo aws/agentcore-cli --pattern "*.tgz" --dir /tmp/pr-tarball
npm install -g /tmp/pr-tarball/aws-agentcore-0.19.0.tgz |
Contributor
|
Claude Security Review: no high-confidence findings. (run) |
agentcore-devx-automation
Bot
removed
the
claude-security-reviewing
agentcore-cli-automation
approved these changes
Jun 17, 2026
agentcore-cli-automation
left a comment
agentcore-cli-automation
left a comment
There was a problem hiding this comment.
LGTM — straightforward removal of gating for web-search. Confirmed:
- The 4 gating points removed (CLI primitive command/options, runtime check in
add gateway-target, top-leveladd/remove web-searchshortcuts, and the two TUI screens) are the right ones. - The deleted
AddScreen.test.tsxcase was specifically testing the gated "Coming soon" state, so removing it is appropriate. src/cli/commands/add/validate.tsalready listsweb-searchunconditionally invalidTypeList, so no changes needed there.- Telemetry events (
add.web-search,remove.web-search) and target-type telemetry shapes already exist insrc/cli/telemetry/schemas/. - Schemas in
src/schema/schemas/mcp.tsacceptwebSearchunconditionally.
The remaining isGatedFeaturesEnabled() ternary for typeDescription (lines 286-288) is still needed because it gates passthrough.
github-actions
Bot
removed
the
agentcore-harness-reviewing
Contributor
Coverage Report
|
Hweinstock
added a commit
that referenced
this pull request
Jun 17, 2026
nborges-aws
added a commit
that referenced
this pull request
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove all gating logic from web-search feature.
Related Issue
Closes #
Documentation PR
Type of Change
Testing
How have you tested the change?
npm run test:unitandnpm run test:integnpm run typechecknpm run lintsrc/assets/, I rannpm run test:update-snapshotsand committed the updated snapshotsChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the
terms of your choice.