fix(frontend): resolve set-state-in-effect in NutritionSettingsPage (#1063)#1075
Merged
ericsocrat merged 1 commit intomainfrom May 1, 2026
Merged
fix(frontend): resolve set-state-in-effect in NutritionSettingsPage (#1063)#1075ericsocrat merged 1 commit intomainfrom
ericsocrat merged 1 commit intomainfrom
Conversation
…1063) Replaces useEffect that synced 5 form fields (diet, allergens, strictDiet, strictAllergen, treatMayContain) from useQuery prefs result with React 19 'adjust state during render' pattern. A prevPrefs state tracks last seen query result; new values written before render completes when prefs identity changes. useEffect import removed as no longer used. Behaviour unchanged.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📸 PR ScreenshotsCaptured 2 screenshots (1 mobile, 1 desktop) for 1 changed page(s):
📥 Download screenshots from workflow artifacts. Captured by PR Screenshots workflow • 2026-05-01 |
There was a problem hiding this comment.
Pull request overview
Updates the Nutrition settings page to eliminate a React Compiler react-hooks/set-state-in-effect warning by replacing an effect-driven “sync query result into local form state” flow with React’s “adjust state during render” pattern.
Changes:
- Removed
useEffectusage/import and introduced aprevPrefssentinel state to detect upstreamprefschanges. - Hydrates 5 local form states (diet/allergens/strict flags) during render when the
prefsquery result reference changes.
Bundle Size Report
✅ Bundle size is within acceptable limits. |
ericsocrat
added a commit
that referenced
this pull request
May 1, 2026
…) (#1077) Phase 2 of #1063 -- resolves 2 of 19 violations (running total: 12/19 across 9 PRs). Two react-hooks/set-state-in-effect warnings in SearchAutocomplete.tsx resolved by adjusting state during render: 1. Refresh recent-searches list on dropdown open: replaced the show-dep useEffect with a prevShow render-phase tracker. Added a lazy initial-state initializer so the list is hydrated on mount when show is already true (preserves existing test contract). 2. Reset activeIndex when suggestions/query change: replaced the multi-dep useEffect with a composite resetKey + prevResetKey render-phase tracker. Pattern: https://react.dev/learn/you-might-not-need-an-effect#adjusting-some-state-when-a-prop-changes Behaviour unchanged. 32/32 vitest pass, eslint and tsc clean. Cross-references: #1067, #1069, #1070, #1071, #1072, #1073, #1074, #1075, #1076. Co-authored-by: ericsocrat <ericsocrat@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 of #1063 - seventh PR, eighth violation of 19. Resolves
src/app/app/settings/nutrition/page.tsx:48.Change
Replaces a
useEffectthat synced 5 form fields (diet,allergens,strictDiet,strictAllergen,treatMayContain) from auseQueryprefsresult with the React 19 'adjust state during render' pattern (https://react.dev/learn/you-might-not-need-an-effect#adjusting-some-state-when-a-prop-changes).A
prevPrefsstate variable tracks the last seen query result; when theprefsreference changes, the new values are written before render completes.The
useEffectimport is removed since the file no longer uses it.Behaviour is unchanged - the form still populates after the query resolves and after refetches.
Verification
eslint- cleanvitest run src/app/app/settings/nutrition/page.test.tsx- 16/16 passtsc --noEmit- cleanProgress