Skip to content

[WIP] Enhance test quality in pkg/workflow/features_test.go #16156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Copilot wants to merge 2 commits into from
+18 −23
Closed

[WIP] Enhance test quality in pkg/workflow/features_test.go #16156

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2c92cc
Initial plan
Copilot Feb 16, 2026
d7f2b7b
Convert features_test.go to use testify assertions
Copilot Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 18 additions & 23 deletions pkg/workflow/features_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import (
"testing"

"github.com/github/gh-aw/pkg/constants"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)

func TestIsFeatureEnabled(t *testing.T) {
Expand Down Expand Up @@ -71,19 +73,16 @@ func TestIsFeatureEnabled(t *testing.T) {
t.Setenv("GH_AW_FEATURES", tt.envValue)

result := isFeatureEnabled(tt.flag, nil)
if result != tt.expected {
t.Errorf("isFeatureEnabled(%q, nil) with env=%q = %v, want %v",
tt.flag, tt.envValue, result, tt.expected)
}
assert.Equal(t, tt.expected, result,
"isFeatureEnabled(%q, nil) with env=%q should return expected value",
tt.flag, tt.envValue)
})
}
}

func TestIsFeatureEnabledNoEnv(t *testing.T) {
result := isFeatureEnabled(constants.FeatureFlag("firewall"), nil)
if result != false {
t.Errorf("isFeatureEnabled(\"firewall\", nil) with no env = %v, want false", result)
}
assert.False(t, result, "feature should be disabled when no env is set")
}

func TestIsFeatureEnabledWithData(t *testing.T) {
Expand Down Expand Up @@ -166,13 +165,13 @@ func TestIsFeatureEnabledWithData(t *testing.T) {
workflowData = &WorkflowData{
Features: tt.frontmatter,
}
require.NotNil(t, workflowData, "WorkflowData should be constructed")
require.NotNil(t, workflowData.Features, "Features map should be set")
}

result := isFeatureEnabled(tt.flag, workflowData)
if result != tt.expected {
t.Errorf("%s: isFeatureEnabled(%q, %+v) with env=%q = %v, want %v",
tt.description, tt.flag, tt.frontmatter, tt.envValue, result, tt.expected)
}
assert.Equal(t, tt.expected, result,
"%s: feature check should return expected value", tt.description)
})
}
}
Expand All @@ -183,9 +182,7 @@ func TestIsFeatureEnabledWithDataNilWorkflow(t *testing.T) {

// When workflowData is nil, should fall back to env
result := isFeatureEnabled(constants.FeatureFlag("firewall"), nil)
if result != true {
t.Errorf("isFeatureEnabled(\"firewall\", nil) with env=firewall = %v, want true", result)
}
assert.True(t, result, "feature should be enabled from env when workflowData is nil")
}

// TestMergedFeaturesAreUsedByIsFeatureEnabled verifies that features merged from imports
Expand Down Expand Up @@ -237,9 +234,8 @@ func TestMergedFeaturesAreUsedByIsFeatureEnabled(t *testing.T) {
for _, tt := range tests {
t.Run(tt.name, func(t *testing.T) {
result := isFeatureEnabled(tt.flag, workflowData)
if result != tt.expected {
t.Errorf("isFeatureEnabled(%q) = %v, want %v", tt.flag, result, tt.expected)
}
assert.Equal(t, tt.expected, result,
"isFeatureEnabled(%q) should return expected value", tt.flag)
})
}
}
Expand All @@ -260,13 +256,12 @@ func TestMergedFeaturesTopLevelPrecedence(t *testing.T) {

// Verify that the overridden value is what isFeatureEnabled sees
overrideResult := isFeatureEnabled(constants.FeatureFlag("override-feature"), workflowData)
if overrideResult != false {
t.Errorf("isFeatureEnabled(\"override-feature\") = %v, want false (top-level override)", overrideResult)
}
assert.False(t, overrideResult,
"top-level feature should override imported value")

// Verify that import-only feature is still accessible
importOnlyResult := isFeatureEnabled(constants.FeatureFlag("import-only"), workflowData)
if importOnlyResult != true {
t.Errorf("isFeatureEnabled(\"import-only\") = %v, want true (from import)", importOnlyResult)
}
assert.True(t, importOnlyResult,
"imported feature should be accessible")

}