[4.2] Remove the SCSS deprecations by dgrammatiko · Pull Request #36906 · joomla/joomla-cms

dgrammatiko · 2022-01-31T22:33:16Z

Pull Request for Issue # .

Summary of Changes

Removing the math.div deprecations from the scss compiler
update Font Awesome to v6
update choices.js to v10

Testing Instructions

Apply this Pr's branch
run npm ci
Check that nothing is broken visually

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

Signed-off-by: dgrammatiko <d.grammatiko@gmail.com>

HarshJaiswani · 2022-02-10T17:24:18Z

I have tested this item ✅ successfully on bcc3ce8

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/36906.}

brianteeman · 2022-02-10T17:29:09Z

-      "version": "5.65.1",
-      "resolved": "https://registry.npmjs.org/codemirror/-/codemirror-5.65.1.tgz",
-      "integrity": "sha512-s6aac+DD+4O2u1aBmdxhB7yz2XU7tG3snOyQ05Kxifahz7hoxnfxIRHxiCSEv3TUC38dIVH8G+lZH9UWSfGQxA=="
+      "version": "5.64.0",


this should be 5.65.1

done, btw not reflecting the actual version in the package.json is the source of those inconsistencies...

# Conflicts: # package-lock.json

roland-d · 2022-03-09T18:44:11Z

@dgrammatiko I sent you a PR to fix the conflict, after that I can merge this PR. Thank you.

36906 conflict fix

dgrammatiko · 2022-03-09T19:08:36Z

after that I can merge this PR

About merging this PR: @brianteeman already spotted some visual changes due to the upgrade to v6 of Font Awesome. This might need some research (it's just comparing the font icon names using the 2 different sites v5 and v6, making some notes and then maybe figure out if some other mapping is making more sense for the current use case, it's a bit of work...)

It would be nice to roll an article that 4.2 will use FA v6 and ask devs to adjust (early) their code eg from:

font-family: "Font Awesome 5 Free";

to

font-family: "Font Awesome 6 Free","Font Awesome 5 Free";

Also this is the only part that needs to be documented

Quy · 2022-03-09T19:13:13Z

Please merge. I noticed it too, however, this can be done in separate PR which I can do.

roland-d · 2022-03-09T19:14:46Z

Thank you @Quy I am just waiting for Drone and AppVeyor to finish.

dgrammatiko · 2022-03-09T19:17:05Z

@roland-d do you want me to do some back port of this to 4.1 (without the FA v6) or someone already on it?

brianteeman · 2022-03-09T19:22:44Z

do/should we really be updating fontawesome? \they are breaking changes AND fs5 is designated LTS

dgrammatiko · 2022-03-09T19:30:20Z

do/should we really be updating fontawesome? \they are breaking changes AND fs5 is designated LTS

FA v5 still has the deprecated div notifications and there is not update but also it's not the end of the world we could override some values locally and fix it in this repo if there's no fix upstream. Anyways, not my decision, I could redo this with the v5...

brianteeman · 2022-03-09T19:36:16Z

the deprecated div notifications
which are not seen by the user

dgrammatiko · 2022-03-09T19:58:04Z

which are not seen by the user

True, but it's annoying for devs (not really a reason) and might be a problem for new contributors (not really, if there was a nice welcoming DX)
Also there's no documentation that states that the node audit/deprecations/etc are irrelevant for the distributed product

FWIW this PR's intention was to just fix the math div deprecations, the FA upgrade shouldn't be part of this. Probably I was too fast to jump on the newest-greatest train without thinking too much. I'll try to do a PR in the 4.1 with only the needed changes and close this. If there's a decision to go with v6, diffing the changes here and making a new pr should be a 5min job...

brianteeman · 2022-03-09T20:01:20Z

agreed

brianteeman · 2022-03-09T20:01:52Z

and 6,1 comes out next week

dgrammatiko · 2022-03-10T13:58:19Z

OK closing here the PR for 4.1 is here: #37243

If anyone still wants to upgrade to FA v6 the code is here

joomleb · 2022-05-22T01:40:46Z

Hi guys,
sorry,I did not understand. At the end FA6 will not be included into the J4.1, right ?
But, Will it be added in J4.2 ?

roland-d · 2022-05-22T07:37:30Z

Hello,

This will not be in Joomla 4.2 nor do I know when it will come.

HDInfautre · 2022-09-13T16:34:56Z

Hi
There are lots of new icons Font Awesome v6 :-)
Do you know when this can be integrated? 4.2.3 ?
or what is the method to integrate it now ? if there is no date

HLeithner · 2022-09-13T18:33:36Z

Font Awesome icon packs are not backward compatible, so upgrading them would break other websites. if we upgrade it, it's
likely to be in Joomla 5.0.

HDInfautre · 2022-09-13T18:50:30Z

Font Awesome icon packs are not backward compatible, so upgrading them would break other websites. if we upgrade it, it's likely to be in Joomla 5.0.

Hi
Sniff, thank you for the clarification.

brb

fd71e2e

joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-4.1-dev labels Jan 31, 2022

pfff

1537b8c

dgrammatiko mentioned this pull request Jan 31, 2022

[4.0-dev] Fixing SCSS issues with division deprecation and math.div() #35648

Closed

dgrammatiko added 2 commits January 31, 2022 23:58

stfu

cc50aa4

enable the buttons again

99b0dd1

dgrammatiko closed this Feb 1, 2022

dgrammatiko deleted the 4.1-dev-fix-scss-div branch February 1, 2022 12:52

dgrammatiko mentioned this pull request Feb 10, 2022

scss depreciated warnings #36991

Closed

dgrammatiko restored the 4.1-dev-fix-scss-div branch February 10, 2022 13:40

dgrammatiko reopened this Feb 10, 2022

dgrammatiko changed the title ~~[skip] Nothing to see here~~ [4.1.x] Remove the SCSS deprecations Feb 10, 2022

dgrammatiko and others added 14 commits February 10, 2022 14:44

Merge branch '4.1-dev' into 4.1-dev-fix-scss-div

ef02f7b

Update settings.json

c7c76da

Delete base.scss

b2d74a2

Delete choices.scss

9ec387a

Update package.json

2cbc0f3

Update template.scss

c97ea0c

Update _variables.scss

d323e56

Update fontawesome.scss

322a2ec

Update joomla-fontawesome.scss

635c3c3

Update _variables.scss

1c83535

Update settings.json

ae9ca99

Update _metismenu.scss

470df6b

update the lock file

0b265f3

Signed-off-by: dgrammatiko <d.grammatiko@gmail.com>

Update codemirror.xml

bcc3ce8

richard67 mentioned this pull request Feb 10, 2022

Removed depriciation warnings in scss #36992

Closed

brianteeman reviewed Feb 10, 2022

View reviewed changes

Merge branch '4.2-dev' into 36906-conflic-fix

e9ba9c2

# Conflicts: # package-lock.json

roland-d mentioned this pull request Mar 9, 2022

36906 conflict fix dgrammatiko/joomla-cms#11

Merged

roland-d added the Conflicting Files label Mar 9, 2022

dgrammatiko added 2 commits March 9, 2022 20:03

Merge pull request #11 from roland-d/36906-conflic-fix

5f4e32b

36906 conflict fix

Merge branch '4.2-dev' into 4.1-dev-fix-scss-div

9b6d502

roland-d removed the Conflicting Files label Mar 9, 2022

dgrammatiko mentioned this pull request Mar 10, 2022

[4.1][NO CACHE] Remove the math.div deprecation #37243

Closed

dgrammatiko closed this Mar 10, 2022

joomla-cms-bot removed the RTC This Pull Request is Ready To Commit label Mar 10, 2022

dgrammatiko mentioned this pull request Mar 12, 2022

[4.1] Remove the math.div deprecation #37255

Merged

dgrammatiko deleted the 4.1-dev-fix-scss-div branch March 12, 2022 14:47

laoneo mentioned this pull request May 26, 2023

Upgrade font awesome to version 6 #40524

Merged

4 tasks

joomleb mentioned this pull request Sep 14, 2023

[2.0.14 Bug] Menu Item > Link Type > Link Icon class JoomShaper/helix-ultimate#346

Closed

Uh oh!

Uh oh!

Conversation

dgrammatiko commented Jan 31, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

Uh oh!

HarshJaiswani commented Feb 10, 2022

Uh oh!

brianteeman Feb 10, 2022

Choose a reason for hiding this comment

Uh oh!

dgrammatiko Feb 10, 2022

Choose a reason for hiding this comment

Uh oh!

roland-d commented Mar 9, 2022

Uh oh!

dgrammatiko commented Mar 9, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Quy commented Mar 9, 2022

Uh oh!

roland-d commented Mar 9, 2022

Uh oh!

dgrammatiko commented Mar 9, 2022

Uh oh!

brianteeman commented Mar 9, 2022

Uh oh!

dgrammatiko commented Mar 9, 2022

Uh oh!

brianteeman commented Mar 9, 2022

Uh oh!

dgrammatiko commented Mar 9, 2022

Uh oh!

brianteeman commented Mar 9, 2022

Uh oh!

brianteeman commented Mar 9, 2022

Uh oh!

dgrammatiko commented Mar 10, 2022

Uh oh!

joomleb commented May 22, 2022

Uh oh!

roland-d commented May 22, 2022

Uh oh!

HDInfautre commented Sep 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

HLeithner commented Sep 13, 2022

Uh oh!

HDInfautre commented Sep 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

dgrammatiko commented Jan 31, 2022 •

edited

Loading

dgrammatiko commented Mar 9, 2022 •

edited

Loading

HDInfautre commented Sep 13, 2022 •

edited

Loading

HDInfautre commented Sep 13, 2022 •

edited

Loading