Migrate gptme to parser provider facade

[mariusvniekerk]

Migrates gptme from the transitional legacy provider adapter to a concrete provider facade implementation. The provider composes JSONLSourceSet for file discovery, watch planning, changed-path classification, lookup, and fingerprinting, then filters to the legacy //conversation.jsonl layout.

Runtime sync dispatch is still unchanged. This PR proves the facade with one narrow single-session JSONL provider while keeping all other agents on legacy adapters until their own migration slices land.

[roborev-ci]

roborev: Combined Review (1c09821)

Summary verdict: no Medium, High, or Critical findings to report.

The only reported issue was Low severity, so it is omitted per the review-combination rules.

---

Panel: ci_default_security | Synthesis: codex, 4s | Members: codex_default (codex/default, done, 3m36s), codex_security (codex/security, done, 2m11s) | Total: 5m51s

[roborev-ci]

roborev: Combined Review (e9558b6)

No issues found.

---

Panel: ci_default_security | Synthesis: codex | Members: codex_default (codex/default, done, 4m41s), codex_security (codex/security, done, 1m56s) | Total: 6m37s

[roborev-ci]

roborev: Review Unavailable (ede515d)

The review agent repeatedly failed to run (likely an agent or configuration error). roborev will try again on the next commit.

Last error: agent: claude-code failed stream: stream errors: You've hit your session limit · resets 5:50am (UTC): exit status 1

[roborev-ci]

roborev: Combined Review (27cbdac)

No Medium, High, or Critical findings were reported.

The only reported issue was Low severity and is omitted per instructions.

---

Panel: ci_default_security | Synthesis: codex, 4s | Members: codex_default (codex/default, done, 5m21s), codex_security (codex/security, done, 2m6s) | Total: 7m31s

[mariusvniekerk]

This change is part of the following stack:

• Design parser provider facade layer #748
  • Add parser provider facade core #751
    • Add JSONL source set helper #752
      • feat(parser): add directory JSONL source helper #756
        • feat(parser): migrate commandcode and iflow providers #757
          • Migrate gptme to parser provider facade #753 ◀
            • feat(parser): migrate deepseek tui provider #758
              • feat(parser): migrate amp and zencoder providers #759
                • feat(parser): migrate pi provider #760
                  • feat(parser): migrate qwen provider #761
                  • feat(parser): migrate workbuddy provider #762
                  • feat(parser): migrate cortex provider #763
                  • feat(parser): migrate kimi provider #764
                  • feat(parser): migrate claw providers #766
                  • feat(parser): migrate qwenpaw provider #767
                  • feat(parser): migrate openhands provider #768
                  • feat(parser): migrate cursor provider #769
                  • feat(parser): migrate vibe provider #770
                  • feat(parser): migrate hermes provider #771
                  • feat(parser): migrate claude provider #772
                  • feat(parser): migrate cowork provider #773
                  • feat(parser): migrate opencode-family providers #774
                  • feat(parser): migrate codex provider #775
                  • feat(parser): migrate gemini copilot providers #776
                  • feat(parser): migrate copilot ide providers #778
                  • feat(parser): migrate positron provider #779
                  • feat(parser): migrate zed shelley providers #780
                  • feat(parser): migrate kiro providers #781
                  • feat(parser): migrate antigravity providers #782
                  • feat(parser): migrate db-backed providers #783
                  • fix(parser): require explicit provider factories #784

_{Change managed by git-spice.}

[roborev-ci]

roborev: Combined Review (569d8db)

No Medium, High, or Critical findings were reported.

The only reported issue was Low severity and has been omitted per the requested threshold.

---

Panel: ci_default_security | Synthesis: codex, 4s | Members: codex_default (codex/default, done, 5m31s), codex_security (codex/security, done, 1m49s) | Total: 7m24s

[roborev-ci]

roborev: Combined Review (95fe1f2)

Summary verdict: one medium issue needs fixing before merge.

Medium

• internal/parser/gptme_provider.go:234 - The source set only filters by basename before JSONLSourceSet dedupes and resolves roots, then applies the gptme <root>/<session>/conversation.jsonl shape afterward. With overlapping configured roots, a broader root can claim the same physical conversation.jsonl as an invalid nested source, causing discovery to drop the valid child-root source and FindSource to report not found.

  Fix: Enforce isGptmeConversationPath(root, path) via IncludePath inside newGptmeSourceSet so invalid root/path pairings are rejected before dedupe and lookup return.

---

Panel: ci_default_security | Synthesis: codex, 6s | Members: codex_default (codex/default, done, 4m57s), codex_security (codex/security, done, 1m25s) | Total: 6m28s

[roborev-ci]

roborev: Combined Review (d08a3b3)

Clean overall, with one Medium regression to confirm before merge.

Medium

• internal/parser/types.go gptme registry entry, affecting internal/ssh/resolve.go:74-79 and internal/sync/parsediff.go:206-218

  Removing DiscoverFunc/FindSourceFunc from the gptme registry entry drops gptme from registry-driven paths still gated on def.DiscoverFunc != nil.

  This means gptme transcripts are omitted from the generated SSH resolve script, so remote SSH sync silently stops transferring them. It also excludes gptme from parse-diff diagnostics, so parsediff --agent gptme now errors with “has no on-disk source to re-parse.”

  This matches the current iflow/commandcode migration state, so it may be an accepted intermediate migration step. Please confirm the provider-shape adapter for ssh/resolve.go and parsediff.go is covered by a follow-up. If remote SSH sync must keep working during the migration, route these paths through provider Discover/FindSource for provider-authoritative agents.

---

Panel: ci_default_security | Synthesis: codex, 8s | Members: codex_default (claude-code/default, done, 8m11s), codex_security (claude-code/security, done, 1m0s) | Total: 9m19s

[roborev-ci]

roborev: Combined Review (b80e47c)

Summary verdict: One medium regression needs addressing; no security findings were reported.

Medium

• internal/parser/types.go:585 - Removing gptme's DiscoverFunc / FindSourceFunc drops it from code paths that still enumerate only file-based agents with DiscoverFunc, notably parse-diff and SSH remote sync resolution. As a result, --agent gptme parse-diff and remote gptme imports may stop working.

  Fix: Keep compatibility wrappers until those paths are provider-aware, or update parse-diff and SSH resolution to include provider-authoritative file-based agents and add gptme coverage.

---

Panel: ci_default_security | Synthesis: codex, 7s | Members: codex_default (codex/default, done, 8m54s), codex_security (codex/security, done, 1m52s) | Total: 10m53s