feat(parser): migrate positron provider

[mariusvniekerk]

Positron now has a concrete parser provider for its workspaceStorage chat-session layout. The provider owns workspace chat discovery, raw and full ID lookup, recursive watch planning, changed-path classification including deleted chat paths and workspace.json fan-out, workspace metadata-aware freshness, hashing, project hints, and parse output through the existing Positron parser.

This keeps Positron on the shared provider interface while preserving its VS Code-style parser normalization and Positron-specific agent identity.

[roborev-ci]

roborev: Combined Review (18e1d56)

Summary verdict: one medium correctness issue remains; no high or critical findings were reported.

Medium

• internal/parser/positron_provider.go:105 — Parse drops parser-emitted usage events by building ParseResult with only Session and Messages, even though ParsePositronSession can populate sess.UsageEvents and the provider advertises AggregateUsageEvents support. Consumers that persist ParseResult.UsageEvents will silently lose Positron token/cost rows.
  • Fix: Set UsageEvents: sess.UsageEvents in the returned ParseResult and add a provider test fixture with usage metadata.

---

Panel: ci_default_security | Synthesis: codex, 6s | Members: codex_default (codex/default, done, 3m38s), codex_security (codex/security, done, 1m15s) | Total: 4m59s

[roborev-ci]

roborev: Review Unavailable (2710ab5)

The review agent repeatedly failed to run (likely an agent or configuration error). roborev will try again on the next commit.

Last error: agent: claude-code failed stream: stream errors: You've hit your session limit · resets 5:50am (UTC): exit status 1

[roborev-ci]

roborev: Combined Review (1c15a5f)

No issues found.

---

Panel: ci_default_security | Synthesis: codex | Members: codex_default (codex/default, done, 9m50s), codex_security (codex/security, done, 2m7s) | Total: 11m57s

[mariusvniekerk]

This change is part of the following stack:

• Design parser provider facade layer #748
  • Add parser provider facade core #751
    • Add JSONL source set helper #752
      • feat(parser): add directory JSONL source helper #756
        • feat(parser): migrate commandcode and iflow providers #757
          • Migrate gptme to parser provider facade #753
            • feat(parser): migrate deepseek tui provider #758
              • feat(parser): migrate amp and zencoder providers #759
                • feat(parser): migrate pi provider #760
                  • feat(parser): migrate qwen provider #761
                  • feat(parser): migrate workbuddy provider #762
                  • feat(parser): migrate cortex provider #763
                  • feat(parser): migrate kimi provider #764
                  • feat(parser): migrate claw providers #766
                  • feat(parser): migrate qwenpaw provider #767
                  • feat(parser): migrate openhands provider #768
                  • feat(parser): migrate cursor provider #769
                  • feat(parser): migrate vibe provider #770
                  • feat(parser): migrate hermes provider #771
                  • feat(parser): migrate claude provider #772
                  • feat(parser): migrate cowork provider #773
                  • feat(parser): migrate opencode-family providers #774
                  • feat(parser): migrate codex provider #775
                  • feat(parser): migrate gemini copilot providers #776
                  • feat(parser): migrate copilot ide providers #778
                  • feat(parser): migrate positron provider #779 ◀
                  • feat(parser): migrate zed shelley providers #780
                  • feat(parser): migrate kiro providers #781
                  • feat(parser): migrate antigravity providers #782
                  • feat(parser): migrate db-backed providers #783
                  • fix(parser): require explicit provider factories #784

_{Change managed by git-spice.}

[roborev-ci]

roborev: Combined Review (b8c0fb0)

Summary verdict: One medium issue remains; no high or critical findings were reported.

Medium

• internal/parser/positron_provider.go:112, internal/sync/engine.go:6779 — ParsePositronSession populates sess.UsageEvents, and the provider advertises AggregateUsageEvents, but the provider result drops those events. The legacy processPositron path also omits them, so Positron sessions with VS Code-style token metadata will not write usage/cost rows.

  Fix: Set UsageEvents: sess.UsageEvents in both the provider ParseResult and processPositron, and add a fixture with result.metadata to assert usage events are preserved.

---

Panel: ci_default_security | Synthesis: codex, 9s | Members: codex_default (codex/default, done, 9m58s), codex_security (codex/security, done, 3m29s) | Total: 13m36s

[roborev-ci]

roborev: Combined Review (d81b50f)

Summary verdict: No medium-or-higher severity findings to report.

Both reviews found no actionable issues at Medium, High, or Critical severity.

---

Panel: ci_default_security | Synthesis: codex, 5s | Members: codex_default (codex/default, done, 8m15s), codex_security (codex/security, done, 29s) | Total: 8m49s

[roborev-ci]

roborev: Combined Review (2a50a0f)

Summary verdict: changes need fixes for one high-severity test regression and one medium-severity usage persistence bug.

High

• internal/parser/provider_shim_scan_test.go:64
  The pending shim list includes visualstudio_copilot_provider.go and vscode_copilot_provider.go, but the anti-shim test asserts pending files still reference a legacy entrypoint. These provider files are already folded, so the parser test will fail.
  Fix: Remove both provider files from pendingShimProviderFiles.

Medium

• internal/parser/positron_provider.go:112
parseVSCodeCopilotData populates sess.UsageEvents, and Positron advertises AggregateUsageEvents, but the provider drops those events from the returned ParseResult. Positron token usage rows will not be persisted.
  Fix: Return UsageEvents: sess.UsageEvents with the result, adjusting the event source to Positron if needed, and add coverage for token metadata.

---

Panel: ci_default_security | Synthesis: codex, 8s | Members: codex_default (codex/default, done, 5m32s), codex_security (codex/security, done, 2m53s) | Total: 8m33s