Skip to content

feat(parser): add directory JSONL source helper#756

Draft
mariusvniekerk wants to merge 1 commit into
provider-jsonl-source-setfrom
provider-directory-jsonl-source-set
Draft

feat(parser): add directory JSONL source helper#756
mariusvniekerk wants to merge 1 commit into
provider-jsonl-source-setfrom
provider-directory-jsonl-source-set

Conversation

@mariusvniekerk

Copy link
Copy Markdown
Collaborator

Several remaining parser migrations share the same one-project-directory JSONL layout. Keeping that source shape in a thin helper lets provider implementations focus on parse behavior while still explicitly forwarding the source methods they support.

The helper embeds JSONLSourceSet and only adds the directory-shape constraint plus default project hints, so it avoids introducing a second provider framework.

@roborev-ci

roborev-ci Bot commented Jun 19, 2026

Copy link
Copy Markdown

roborev: Combined Review (7184a46)

No issues found.


Panel: ci_default_security | Synthesis: codex | Members: codex_default (codex/default, done, 1m46s), codex_security (codex/security, done, 13s) | Total: 1m59s

@roborev-ci

roborev-ci Bot commented Jun 20, 2026

Copy link
Copy Markdown

roborev: Combined Review (55cfa0e)

No issues found.


Panel: ci_default_security | Synthesis: codex | Members: codex_default (claude-code/default, done, 1m59s), codex_security (claude-code/security, done, 1m0s) | Total: 2m59s

@mariusvniekerk mariusvniekerk force-pushed the provider-jsonl-source-set branch from fa9cef2 to 611917e Compare June 21, 2026 00:40
@mariusvniekerk mariusvniekerk force-pushed the provider-directory-jsonl-source-set branch from 55cfa0e to 5f1b70c Compare June 21, 2026 00:40
@roborev-ci

roborev-ci Bot commented Jun 21, 2026

Copy link
Copy Markdown

roborev: Combined Review (5f1b70c)

No issues found.


Panel: ci_default_security | Synthesis: codex | Members: codex_default (codex/default, done, 2m15s), codex_security (codex/security, done, 34s) | Total: 2m49s

@mariusvniekerk

mariusvniekerk commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator Author

This change is part of the following stack:

Change managed by git-spice.

@roborev-ci

roborev-ci Bot commented Jun 21, 2026

Copy link
Copy Markdown

roborev: Combined Review (23d383e)

No issues found.


Panel: ci_default_security | Synthesis: codex | Members: codex_default (codex/default, done, 2m4s), codex_security (codex/security, done, 42s) | Total: 2m46s

@roborev-ci

roborev-ci Bot commented Jun 21, 2026

Copy link
Copy Markdown

roborev: Combined Review (5ef4189)

No Medium, High, or Critical findings to report.

The only reported issue was Low severity and is omitted per instructions.


Panel: ci_default_security | Synthesis: codex, 4s | Members: codex_default (codex/default, done, 6m16s), codex_security (codex/security, done, 1m7s) | Total: 7m27s

@mariusvniekerk mariusvniekerk force-pushed the provider-jsonl-source-set branch from 611917e to 216e363 Compare June 23, 2026 23:55
@mariusvniekerk mariusvniekerk force-pushed the provider-directory-jsonl-source-set branch from 5ef4189 to a302cd4 Compare June 23, 2026 23:55
@roborev-ci

roborev-ci Bot commented Jun 24, 2026

Copy link
Copy Markdown

roborev: Combined Review (a302cd4)

No issues found.


Panel: ci_default_security | Synthesis: codex | Members: codex_default (codex/default, done, 4m39s), codex_security (codex/security, done, 14s) | Total: 4m53s

Several remaining parser migrations share the same one-project-directory JSONL layout. Keeping that source shape in a thin helper lets provider implementations focus on parse behavior while still explicitly forwarding the source methods they support.

The helper embeds JSONLSourceSet and only adds the directory-shape constraint plus default project hints, so it avoids introducing a second provider framework.

feat(parser): share virtual source path helpers

SQLite and trace-backed providers use the same physical-container plus logical-source path shape. Keeping each parser's split/join logic local makes stored hint compatibility more fragile as providers migrate onto the facade.

Introduce one reusable virtual source path helper and move the existing Kiro SQLite virtual path handling onto it on the low helper branch, so later provider branches can reuse the same contract as the stack restacks.

Validation: go test -tags "fts5" ./internal/parser -run 'Test(VirtualSourcePath|ParseVirtualSourcePath|ParseKiroSQLiteVirtualPath|JSONLSourceSet|DirectoryJSONLSourceSet)' -count=1 -v; go test -tags "fts5" ./internal/parser -count=1; go vet ./...; go fmt ./...; git diff --check

feat(parser): add sibling metadata source helper

Several provider migrations have a primary transcript source plus sibling metadata files that affect watch routing and freshness. Leaving that pattern entirely provider-local keeps the facade migration dependent on ad hoc sidecar handling even after the JSONL helper exists.

Add a small composable source helper that embeds JSONLSourceSet, maps sibling file events back to the primary source, and fingerprints sibling freshness alongside the source. This keeps concrete providers explicit while giving sidecar-backed migrations a shared source-layer contract.

Validation: go test -tags "fts5" ./internal/parser -run TestSiblingMetadataSourceSetMapsSiblingEventsToPrimarySource -count=1 -v; go test -tags "fts5" ./internal/parser -run TestSiblingMetadataSourceSetFingerprintsSourceWithoutOpaque -count=1 -v; go test -tags "fts5" ./internal/parser -run 'Test(SiblingMetadataSourceSet|VirtualSourcePath|ParseVirtualSourcePath|ParseKiroSQLiteVirtualPath|JSONLSourceSet|DirectoryJSONLSourceSet)' -count=1 -v; go test -tags "fts5" ./internal/parser -count=1; go vet ./...; ./custom-gcl run --config .golangci.nilaway.yml ./internal/parser; go fmt ./...; git diff --check

fix(parser): thread ctx through sibling metadata source lookups
@mariusvniekerk mariusvniekerk force-pushed the provider-jsonl-source-set branch from 216e363 to 5e06aa5 Compare June 25, 2026 05:47
@mariusvniekerk mariusvniekerk force-pushed the provider-directory-jsonl-source-set branch from a302cd4 to 6c48133 Compare June 25, 2026 05:47
@roborev-ci

roborev-ci Bot commented Jun 25, 2026

Copy link
Copy Markdown

roborev: Combined Review (6c48133)

No issues found.


Panel: ci_default_security | Synthesis: codex | Members: codex_default (codex/default, done, 4m25s), codex_security (codex/security, done, 1m7s) | Total: 5m32s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant