Skip to content

fix(web): name plugin credential actions - #40265

Draft
lyzno1 wants to merge 1 commit into
mainfrom
codex/a11y-plugin-credential-actions
Draft

fix(web): name plugin credential actions#40265
lyzno1 wants to merge 1 commit into
mainfrom
codex/a11y-plugin-credential-actions

Conversation

@lyzno1

@lyzno1 lyzno1 commented Aug 9, 2026

Copy link
Copy Markdown
Member

Summary

  • Give the plugin credential Rename, Edit, and Delete icon buttons the accessible names already shown in their tooltips.
  • Hide each CSS icon from the accessibility tree because its button now owns the action semantics.
  • Make the owner tests activate those actions by role and name instead of button order or icon class.

Behavior contract

  • Rename enters the existing inline rename flow.
  • Edit passes the same credential values to the existing edit callback.
  • Delete passes the same credential id to the existing delete callback and still stops row-click propagation.
  • Permission, enterprise, borrowed-credential, disabled, and OAuth visibility rules remain unchanged.

Scope boundary

This PR intentionally does not change the clickable credential row or the inline rename input. The row keyboard model and the Dify UI field/form migration are separate higher-risk owner changes.

Visual regression

No visual change is expected. This PR does not change elements, classes, styles, layout, dimensions, hover visibility, node order, event handlers, or focus styling; it only adds ARIA attributes.

Validation

  • pnpm exec vp check app/components/plugins/plugin-auth/authorized/tests/item.spec.tsx (0 errors, 0 warnings)
  • pnpm exec vp test run app/components/plugins/plugin-auth/authorized/tests/item.spec.tsx (37/37)
  • pnpm check (0 errors, 2059 existing warnings)
  • Focused production lint exposes 3 pre-existing owner errors: deprecated Input import plus the clickable credential row missing role and keyboard handling.
  • node scripts/lint-a11y.mjs confirms only the same 2 pre-existing clickable-row accessibility errors.

From Codex

@github-actions github-actions Bot added the web This relates to changes on the web. label Aug 9, 2026
@codecov

codecov Bot commented Aug 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.42%. Comparing base (e036075) to head (10af8f8).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #40265   +/-   ##
=======================================
  Coverage   86.41%   86.42%           
=======================================
  Files        5107     5107           
  Lines      290731   290752   +21     
  Branches    57917    57923    +6     
=======================================
+ Hits       251245   251270   +25     
+ Misses      34545    34541    -4     
  Partials     4941     4941           
Flag Coverage Δ
dify-ui 93.49% <ø> (ø)
web 86.11% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

web This relates to changes on the web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant