OCPBUGS-44967: Reconcile SecretProvider for CNCC on ARO HCP

[bryan-cox]

What this PR does / why we need it:
Reconcile the SecretProviderClass for the cluster network operator for ARO HCP deployments. The SecretProviderClass is used by the Secrets Store CSI driver to mount a certificate to a volume in the ingress pod deployment.

Which issue(s) this PR fixes:
Fixes OCPBUGS-44967

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [bryan-cox]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

✅ Deploy Preview for hypershift-docs ready!

Name	Link
🔨 Latest commit	7baa52b
🔍 Latest deploy log	https://app.netlify.com/sites/hypershift-docs/deploys/673c1231f45a920008598d3d
😎 Deploy Preview	https://deploy-preview-4903--hypershift-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[openshift-ci-robot]

@bryan-cox: This pull request references HOSTEDCP-2036 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target only the "4.18.0" version, but multiple target versions were set.

Details

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bryan-cox]

Needs the following PRs before we can continue with this one:

• OCPBUGS-44964: Reconcile SecretProviderClass for Ingress on ARO HCP #4884
• HOSTEDCP-2035: Set up Azure authentication with cert for ARO HCP cluster-network-operator#2522
• HOSTEDCP-2035: Use Client Cert Auth for ARO HCP deployments cloud-network-config-controller#156

[openshift-ci-robot]

@bryan-cox: This pull request references Jira Issue OCPBUGS-44967, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.19.0) matches configured target version for branch (4.19.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[bryan-cox]

/retest

[csrwng]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 592c231 and 2 for PR HEAD 87af101 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 8326d86 and 2 for PR HEAD 87af101 in total

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 8326d86 and 2 for PR HEAD 87af101 in total

[bryan-cox]

/test e2e-aks

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 8326d86 and 2 for PR HEAD 87af101 in total

[openshift-ci]

@bryan-cox: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-ci-robot]

@bryan-cox: Jira Issue OCPBUGS-44967: All pull requests linked via external trackers have merged:

• openshift/hypershift#4903

Jira Issue OCPBUGS-44967 has been moved to the MODIFIED state.

Details

In response to this:

What this PR does / why we need it:
Reconcile the SecretProviderClass for the cluster network operator for ARO HCP deployments. The SecretProviderClass is used by the Secrets Store CSI driver to mount a certificate to a volume in the ingress pod deployment.

Which issue(s) this PR fixes:
Fixes OCPBUGS-44967

Checklist

• Subject and description added to both, commit and PR.
• Relevant issues have been referenced.
• This change includes docs.
• This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.19.0-202411282109.p0.g08c85f3.assembly.stream.el9.
All builds following this will include this PR.

[bryan-cox]

/jira backport release-4.18,release-4.17

[openshift-ci-robot]

@bryan-cox: The following backport issues have been created:

• OCPBUGS-45347 for branch release-4.18
• OCPBUGS-45348 for branch release-4.17

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18
/cherrypick release-4.17

Details

In response to this:

/jira backport release-4.18,release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@openshift-ci-robot: #4903 failed to apply on top of branch "release-4.17":

Applying: Reconcile SecretProvider for CNCC on ARO HCP
Using index info to reconstruct a base tree...
M	control-plane-operator/controllers/hostedcontrolplane/cno/clusternetworkoperator.go
M	control-plane-operator/controllers/hostedcontrolplane/hostedcontrolplane_controller.go
Falling back to patching base and 3-way merge...
Auto-merging control-plane-operator/controllers/hostedcontrolplane/hostedcontrolplane_controller.go
Auto-merging control-plane-operator/controllers/hostedcontrolplane/cno/clusternetworkoperator.go
CONFLICT (content): Merge conflict in control-plane-operator/controllers/hostedcontrolplane/cno/clusternetworkoperator.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Reconcile SecretProvider for CNCC on ARO HCP

Details

In response to this:

@bryan-cox: The following backport issues have been created:

• OCPBUGS-45347 for branch release-4.18
• OCPBUGS-45348 for branch release-4.17

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.18
/cherrypick release-4.17

In response to this:

/jira backport release-4.18,release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.