Skip to content

docs(bounties): Add recent paid proof rows#448

Merged
ramimbo merged 2 commits into
ramimbo:mainfrom
campersurfer:campersurfer/docs-paid-bounty-proofs-426
May 26, 2026
Merged

docs(bounties): Add recent paid proof rows#448
ramimbo merged 2 commits into
ramimbo:mainfrom
campersurfer:campersurfer/docs-paid-bounty-proofs-426

Conversation

@campersurfer
Copy link
Copy Markdown
Contributor

@campersurfer campersurfer commented May 26, 2026

Summary: Add newly accepted MRWK payout rows to docs/paid-bounties.md, including the just-paid documentation bounty PR 446, with proof links and a docs test guard.

Evidence: The live accepted-work API for github:campersurfer reports accepted_awards=4 and accepted_mrwk="400". It lists PR 445 paid 75 MRWK at ledger sequence 699 with proof f5b9b286c4cfefe6de73198dd7be5b8d5e1013264623573b7e49488dd6efaecb, and PR 446 paid 50 MRWK under the documentation bounty at ledger sequence 715 with proof bba272164648c1bca33710226173a350d002a22f23aa1bf24c46ec594cf2cc9c.

Validation: Added the docs test first and confirmed it failed before updating docs/paid-bounties.md. After the docs update, python -m pytest tests/test_docs_public_urls.py::test_paid_bounties_lists_recent_docs_payments -q, python scripts/docs_smoke.py, python -m pytest tests/test_docs_public_urls.py -q, ruff check tests/test_docs_public_urls.py, ruff format --check tests/test_docs_public_urls.py, and git diff --check all passed locally.

This is a focused public documentation update for paid bounty proof indexing. It does not claim cash value, liquidity, redemption, bridge, exchange, off-ramp, price, or private-key behavior.

Bounty #426

Summary by CodeRabbit

  • Documentation

    • Updated the public "Paid MRWK Bounties" table to add two newly accepted bounty entries with recipient names, payout amounts, and on-chain proof links; adjusted surrounding rows for consistency.
  • Tests

    • Added an automated check to verify the paid-bounties documentation contains the expected recent entries and proof references.

Review Change Stack

Add newly accepted paid bounty rows for PRs 445 and 446 to the public paid-bounties index.

Guard the new PR and proof links with a focused docs test so the index does not silently lose these recent payments.

Refs ramimbo#426

Co-Authored-By: OpenAI Codex <codex@openai.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 969e20e6-198f-462c-ad1e-c6c1a3aa5b88

📥 Commits

Reviewing files that changed from the base of the PR and between 179b3e8 and 31b7a5f.

📒 Files selected for processing (1)
  • tests/test_docs_public_urls.py

📝 Walkthrough

Walkthrough

This PR updates the paid bounties documentation table by adding two new accepted bounty entries for 2026-05-26 (issues #426 and #411) with corresponding PR links, recipients, payout amounts, and proof URLs. A new test is added to validate that the document contains the expected PR references and content.

Changes

Bounty Documentation Update

Layer / File(s) Summary
Bounty records and validation
docs/paid-bounties.md, tests/test_docs_public_urls.py
Two new paid bounty table rows for 2026-05-26 are added with issue links, PR references (50 MRWK and 75 MRWK payouts), and proof URLs. A new test function verifies the document includes PR links #445 and #446, plus two specific content hashes.

Possibly related issues

  • ramimbo/mergework#408: This PR directly implements the 2026-05-26 bounty reconciliation requested in this issue by adding the two new documented entries.

Possibly related PRs

  • ramimbo/mergework#414: Overlaps on updating docs/paid-bounties.md for the same 2026-05-26 bounty entries and validates them through test assertions.
  • ramimbo/mergework#432: Also modifies docs/paid-bounties.md for the 2026-05-26 entries (issue #411) and adds a matching tests/test_docs_public_urls.py validation assertion.
🚥 Pre-merge checks | ✅ 5 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Bounty Pr Focus ⚠️ Warning Commit has 129 files; PR stated only docs/paid-bounties.md and tests/test_docs_public_urls.py should change. Includes entire unrelated codebase. Isolate bounty #426/#411 changes to stated two files only; remove full-repo initialization and application code from this PR.
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly names the changed surface (docs/paid-bounties.md) and describes the specific action (adding recent paid proof rows).
Description check ✅ Passed The description covers all critical sections: summary of changes, evidence from the live API, validation steps with test results, and bounty reference; required test checkboxes are documented as passed.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Mergework Public Artifact Hygiene ✅ Passed PR adds factual ledger payment records with no investment claims, price claims, cash-out claims, or private security details; MRWK references are amounts only, ledger proofs are public hashes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@campersurfer campersurfer marked this pull request as ready for review May 26, 2026 18:45
@ramimbo ramimbo added the mrwk:needs-info More information needed label May 26, 2026
@ramimbo
Copy link
Copy Markdown
Owner

ramimbo commented May 26, 2026

This opened after the 2026-05-26 maintainer batch was already merged and deployed. Holding it for the next pass: it needs current-head review coverage and mergeability before acceptance/payment.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 8f496654-b451-416c-abd4-e7c613d215a7

📥 Commits

Reviewing files that changed from the base of the PR and between 12c3dbd and 179b3e8.

📒 Files selected for processing (2)
  • docs/paid-bounties.md
  • tests/test_docs_public_urls.py

Comment thread tests/test_docs_public_urls.py Outdated
Copy link
Copy Markdown
Contributor

@GHX5T-SOL GHX5T-SOL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed current head 179b3e82e1dc7847c7eb24fb86df8c8670ec0b68.

The documentation rows themselves match the recent payment evidence for PR #445 and PR #446, and the diff is tightly scoped to docs/paid-bounties.md plus tests/test_docs_public_urls.py. I agree with CodeRabbit's test-strengthening comment and would address it before merge because this PR's regression guard is meant to protect the PR/proof mapping, not just the presence of two PR URLs and two proof hashes somewhere in the file.

The current test_paid_bounties_lists_recent_docs_payments uses four independent substring assertions. A local mutation that swaps the two new rows' proof labels and proof hashes still satisfies those four assertions, while exact row-level assertions for PR #445 -> f5b9b286... and PR #446 -> bba27216... fail. Please assert row-level fragments or full expected rows so the test proves each accepted work item is tied to the right proof.

Validation on this head:

  • .venv/bin/python -m pytest tests/test_docs_public_urls.py::test_paid_bounties_lists_recent_docs_payments -q -> 1 passed.
  • .venv/bin/python -m pytest tests/test_docs_public_urls.py -q -> 23 passed.
  • .venv/bin/python scripts/docs_smoke.py -> docs smoke ok.
  • .venv/bin/python -m ruff check tests/test_docs_public_urls.py -> passed.
  • .venv/bin/python -m ruff format --check tests/test_docs_public_urls.py -> 1 file already formatted.
  • git diff --check origin/main...HEAD -> passed.
  • git diff origin/main...HEAD | gitleaks stdin --no-banner --redact --exit-code 1 -> no leaks found.

No wallet material, private keys, private data, or price/off-ramp claims were used.

Copy link
Copy Markdown
Contributor

@adliebe adliebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed PR #448 at head 179b3e82e1dc7847c7eb24fb86df8c8670ec0b68. No blockers found.

Evidence checked:

  • The diff is intentionally small: docs/paid-bounties.md plus tests/test_docs_public_urls.py, 11 inserted lines total.
  • The two new paid-bounty rows match the live public proof API:
    • bba272164648c1bca33710226173a350d002a22f23aa1bf24c46ec594cf2cc9c => kind=bounty_payment, issue #426, amount 50, recipient github:campersurfer, submission PR #446, ledger 715.
    • f5b9b286c4cfefe6de73198dd7be5b8d5e1013264623573b7e49488dd6efaecb => kind=bounty_payment, issue #411, amount 75, recipient github:campersurfer, submission PR #445, ledger 699.
  • The copy stays in the existing public-proof index format and does not add price, liquidity, exchange, bridge, off-ramp, or payout-guarantee claims.

Validation run locally on this head:

  • .venv\Scripts\python.exe -m pytest tests/test_docs_public_urls.py::test_paid_bounties_lists_recent_docs_payments -q -> 1 passed
  • .venv\Scripts\python.exe -m pytest tests/test_docs_public_urls.py -q -> 23 passed
  • .venv\Scripts\python.exe scripts/docs_smoke.py -> docs smoke ok
  • .venv\Scripts\ruff.exe check docs/paid-bounties.md tests/test_docs_public_urls.py -> passed
  • .venv\Scripts\ruff.exe format --check tests/test_docs_public_urls.py -> 1 file already formatted
  • git diff --check 12c3dbd462d6647d50bfc8115b852e7cb338bb5b..179b3e82e1dc7847c7eb24fb86df8c8670ec0b68 -> clean

Assert row-level PR-to-proof mappings for the recent paid bounty rows so swapped proof hashes fail the regression guard.

Refs ramimbo#426
Co-Authored-By: OpenAI Codex <noreply@openai.com>
@campersurfer
Copy link
Copy Markdown
Contributor Author

Updated in commit 31b7a5f to address the row-integrity review finding. The test now asserts each full row fragment, including the expected bounty issue, PR, recipient, amount, proof label, and proof URL, so a swapped PR/proof mapping fails.\n\nValidation:\n- Temporarily swapped the two new proof rows locally; the tightened test failed on the expected missing #426/PR #446 -> bba27216 row. Reverted the mutation before committing.\n- /Users/juliebush/mergework/.venv/bin/python -m pytest tests/test_docs_public_urls.py::test_paid_bounties_lists_recent_docs_payments -q -> 1 passed\n- /Users/juliebush/mergework/.venv/bin/python -m pytest tests/test_docs_public_urls.py -q -> 23 passed\n- /Users/juliebush/mergework/.venv/bin/python scripts/docs_smoke.py -> docs smoke ok\n- /Users/juliebush/mergework/.venv/bin/ruff check tests/test_docs_public_urls.py -> passed\n- /Users/juliebush/mergework/.venv/bin/ruff format --check tests/test_docs_public_urls.py -> 1 file already formatted\n- git diff --check -> passed

Copy link
Copy Markdown
Contributor

@GHX5T-SOL GHX5T-SOL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-reviewed current head 31b7a5f1109ef1cfca4dcbdf05a0c1bdb37bc2ea; this resolves my earlier row-integrity change request.

The updated test now asserts full row fragments for the two new paid-bounty entries, including issue link, PR link, recipient, MRWK amount, proof label, and proof URL. That covers the PR-to-proof mapping problem I flagged on the prior head, so swapped proof labels/hashes would no longer satisfy the regression guard.

Validation on this head:

  • .venv/bin/python -m pytest tests/test_docs_public_urls.py::test_paid_bounties_lists_recent_docs_payments -q -> 1 passed.
  • .venv/bin/python -m pytest tests/test_docs_public_urls.py -q -> 23 passed.
  • .venv/bin/python scripts/docs_smoke.py -> docs smoke ok.
  • .venv/bin/python -m ruff check tests/test_docs_public_urls.py -> passed.
  • .venv/bin/python -m ruff format --check tests/test_docs_public_urls.py -> 1 file already formatted.
  • git diff --check origin/main...HEAD -> passed.
  • git diff origin/main...HEAD | gitleaks stdin --no-banner --redact --exit-code 1 -> no leaks found.
  • GitHub CI run 26469101907 -> success.

No wallet material, private keys, private data, or price/off-ramp claims were used.

Copy link
Copy Markdown
Contributor

@adliebe adliebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up review on current head 31b7a5f1109ef1cfca4dcbdf05a0c1bdb37bc2ea.

I re-checked the update after PR #448 moved from 179b3e82e1dc7847c7eb24fb86df8c8670ec0b68 to 31b7a5f1109ef1cfca4dcbdf05a0c1bdb37bc2ea. The only post-review delta is in tests/test_docs_public_urls.py, where the recent paid-proof assertions were strengthened.

Current-head validation:

  • pytest tests/test_docs_public_urls.py::test_paid_bounties_lists_recent_docs_payments -q -> 1 passed
  • pytest tests/test_docs_public_urls.py -q -> 23 passed
  • python scripts/docs_smoke.py -> docs smoke ok
  • ruff check docs/paid-bounties.md tests/test_docs_public_urls.py -> All checks passed
  • ruff format --check tests/test_docs_public_urls.py -> already formatted
  • git diff --check 12c3dbd462d6647d50bfc8115b852e7cb338bb5b..31b7a5f1109ef1cfca4dcbdf05a0c1bdb37bc2ea -> clean

No new blockers found.

Copy link
Copy Markdown

@weilixiong weilixiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — recent paid proof rows for #445/#446 with test assertion for content integrity. Docs+test only, zero risk.

@ramimbo ramimbo merged commit e92ee01 into ramimbo:main May 26, 2026
2 checks passed
@ramimbo ramimbo added mrwk:accepted Maintainer accepted for payout mrwk:paid Ledger payment recorded and removed mrwk:needs-info More information needed labels May 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mrwk:accepted Maintainer accepted for payout mrwk:paid Ledger payment recorded

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants