fix: Do not sort listeners differently depending on their type - #162
Merged
provokateurin merged 1 commit intoJul 6, 2026
Merged
Conversation
9 tasks
provokateurin
approved these changes
Jul 6, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #162 +/- ##
============================================
- Coverage 99.18% 99.17% -0.01%
Complexity 111 111
============================================
Files 7 7
Lines 367 364 -3
============================================
- Hits 364 361 -3
Misses 3 3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
With array_multisort, when priority is the same it would fallback to comparing values, and PHP will sort Closures after array callables. This is not something we want as it means turning an array callable into a Closure would potentially change its order, leading to unexpected side-effects. Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
fix/sort-array-and-closure-the-same
branch
from
July 6, 2026 12:38
7830d23 to
59fbd33
Compare
provokateurin
changed the title
This was referenced Jul 7, 2026
|
would be great this change would be covered by a test-case |
This was referenced Jul 12, 2026
phil-davis
added a commit
to phil-davis/event
that referenced
this pull request
Jul 14, 2026
This tests the change in sabre-io#162 that makes sure not to sort listeners that are of equal priority, but to preserve the order in which they were created. Signed-off-by: Phillip Davis <phil@jankaritech.com>
Contributor
See #172 |
phil-davis
added a commit
that referenced
this pull request
Jul 14, 2026
This tests the change in #162 that makes sure not to sort listeners that are of equal priority, but to preserve the order in which they were created. Signed-off-by: Phillip Davis <phil@jankaritech.com>
phil-davis
added a commit
that referenced
this pull request
Jul 14, 2026
This tests the change in #162 that makes sure not to sort listeners that are of equal priority, but to preserve the order in which they were created. Signed-off-by: Phillip Davis <phil@jankaritech.com>
Member
|
awesome - thank you @phil-davis accidentally posted the above comment with my 2nd account ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With array_multisort, when priority is the same it would fallback to comparing values, and PHP will sort Closures after array callables.
This is not something we want as it means turning an array callable into a Closure would potentially change its order, leading to unexpected side-effects.
I did not check the code for other uses of
array_multisort.