P2.6: drop @deprecated AuditService delegators, move @internal helpers to AuditRecorder#112
Draft
sjelfull wants to merge 1 commit into
Draft
P2.6: drop @deprecated AuditService delegators, move @internal helpers to AuditRecorder#112sjelfull wants to merge 1 commit into
sjelfull wants to merge 1 commit into
Conversation
…s to AuditRecorder
Owner
Author
This was referenced Apr 28, 2026
Draft
This was referenced May 14, 2026
bd44821 to
8f9b5e7
Compare
6185ea0 to
24c70f2
Compare
8f9b5e7 to
bd44821
Compare
24c70f2 to
6185ea0
Compare
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
P2.6: drop @deprecated AuditService delegators, move @internal helpers to AuditRecorder
Removes the backward-compatibility shim layer that was keeping the old
AuditServiceAPI alive. The delegator methods (AuditService::record(),AuditService::getRecords(), etc.) were marked@deprecatedin P1.1 and have been dead weight since P2.3 finished rewiring all event listeners to the handler services. This branch deletes them and moves the@internalhelper methods that legitimately belong onAuditRecorder(where they were always called from).The result:
AuditServicedrops from ~500 LOC to a thin service-locator shell.AuditRecordergains the helpers it was already using via cross-service calls.What changed
src/services/AuditService.php— 427 lines deleted. All@deprecateddelegator methods removed. The class now only wires up the service container.src/services/AuditRecorder.php(+116 LOC) — absorbs the@internalhelpers previously living inAuditService:applyOverrides(),buildSnapshot(), and related utilities. No behavior change — these were already called fromAuditRecordervia$this->audit->auditService->helper().BackupHandler,ElementHandler,PluginHandler,RouteHandler,SchemaHandler,SettingsHandler,UserGroupHandler,UserHandler) — update internal calls from$this->audit->auditService->helper()to$this->recorder->helper()now that the helpers live onAuditRecorder.AuditService::references to the correctAuditRecorder::surface.Tests
Stacked on
p2.5-ci-php-matrix-hygiene(#111)