Phase 1.5 — UI: DiffRenderer + 20 Twig templates + asset bundle#94
Draft
sjelfull wants to merge 1 commit into
Draft
Phase 1.5 — UI: DiffRenderer + 20 Twig templates + asset bundle#94sjelfull wants to merge 1 commit into
sjelfull wants to merge 1 commit into
Conversation
This was referenced Apr 26, 2026
- Add DiffRenderer service wrapping jfcherng/php-diff + caxy/php-htmldiff - Register diffRenderer component + expose via craft.audit.diff in Twig - AuditDiffAsset bundle + diff.css (namespaced, dark-mode via CSS custom properties and both media-query + body.dark selectors) - 20 per-handler Twig templates under src/templates/_diff/: index (dispatcher), plain, color, richtext, date, boolean, option, multi-option, relation, money, table, matrix, neo, supertable, vizy, seo, generic, config, error, truncated - Register asset bundle on audit/index and audit/details actions - 14 DiffRendererTest cases (truncation, identical, empty, HTML/text/JSON, XSS escape, malformed HTML fallback) - Tests: 114 passed, 1 skipped (was 100 passed) — +14
95c98f0 to
7417e8d
Compare
dea52c0 to
ad48666
Compare
Owner
Author
📚 Stack navigationPart of the FRE-56 v3 refactor — 12-branch stack via git-spice. Merge in order: bottom-up, each PR rebases the next.
Quick jump📌 Reviewing: focus on the single commit. BC preserved via @deprecated delegators. Tests: 49 → 131 across the full stack, fresh-DB-verified per branch. CI: ECS + PHPStan green per branch. |
This was referenced Apr 27, 2026
Owner
Author
This was referenced Apr 28, 2026
This was referenced May 14, 2026
7417e8d to
da2dd9e
Compare
ad48666 to
3fe508a
Compare
da2dd9e to
7417e8d
Compare
3fe508a to
ad48666
Compare
This was referenced May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the v3 refactor stack for FRE-56. Closes FRE-128.
Diff: 28 files changed, 1494 insertions(+), 1 deletion(-)
Tests: 100 → 114 (+14)
Verified on fresh DB:
DROP DATABASE; pestgreenStack navigation
↑ Builds on #93
project-config-tracking(P1.4)↓ Followed by #95
tests-coverage-expansion(P1.6)Review notes
AuditServiceAPI still works via @deprecated delegators