Skip to content

Phase 1.6 — Tests: migration + integration + enum coverage (+19 tests)#95

Draft
sjelfull wants to merge 1 commit into
ui-improvements-diff-renderingfrom
tests-coverage-expansion
Draft

Phase 1.6 — Tests: migration + integration + enum coverage (+19 tests)#95
sjelfull wants to merge 1 commit into
ui-improvements-diff-renderingfrom
tests-coverage-expansion

Conversation

@sjelfull
Copy link
Copy Markdown
Owner

@sjelfull sjelfull commented Apr 26, 2026

Part of the v3 refactor stack for FRE-56. Closes FRE-129.

Diff: 5 files changed, 284 insertions(+)
Tests: 114 → 133 (+19)
Verified on fresh DB: DROP DATABASE; pest green

Stack navigation

↑ Builds on #94 ui-improvements-diff-rendering (P1.5)
↓ Followed by #96 decompose-elements-users-groups (P2.1)

Review notes

  • Single-commit branch — review the commit, not just the diff
  • BC preserved — old AuditService API still works via @deprecated delegators
  • This is a draft — not a request to merge yet. Marked ready when the stack is approved end-to-end.

@sjelfull
Copy link
Copy Markdown
Owner Author

📚 Stack navigation

Part of the FRE-56 v3 refactor — 12-branch stack via git-spice. Merge in order: bottom-up, each PR rebases the next.

# Stage Title
#90 P1.1 Foundation — enum + JSON migration
#91 P1.2 Core services — recorder, diff, registry
#92 P1.3 15 field handlers
#93 P1.4 Project config tracking
#94 P1.5 UI — diff renderer + 20 templates
#95 P1.6 Tests — +19 coverage
#96 P2.1 Decompose — Element/User/UserGroup handlers
#97 P2.2 Decompose — 5 more handlers
#98 P2.3 Repoint event wiring
#99 P2.4 Tests — migrate to enum
#111 P2.5 CI — PHP 8.2/8.3/8.4 matrix
#110 P3.0 Docs — escape hatch (filter-records, getting-started, events)

Quick jump

#94 P1.5#96 P2.1


📌 Reviewing: focus on the single commit. BC preserved via @deprecated delegators. Tests: 49 → 131 across the full stack, fresh-DB-verified per branch. CI: ECS + PHPStan green per branch.

@sjelfull
Copy link
Copy Markdown
Owner Author

sjelfull commented Apr 28, 2026

This change is part of the following stack:

Change managed by git-spice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant