feat: implement CairoLayout::new from layout name and dynamic params#2362
Conversation
|
7fb1266 to
14d555d
Compare
|
Benchmark Results for unmodified programs 🚀
|
14d555d to
a690cb4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2362 +/- ##
==========================================
+ Coverage 96.07% 96.08% +0.01%
==========================================
Files 105 105
Lines 37737 37756 +19
==========================================
+ Hits 36254 36277 +23
+ Misses 1483 1479 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a690cb4 to
a44f7b5
Compare
YairVaknin-starkware
left a comment
There was a problem hiding this comment.
@YairVaknin-starkware reviewed 5 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on dorimedini-starkware and Yael-Starkware).
vm/src/types/instance_definitions/diluted_pool_instance_def.rs line 7 at r2 (raw file):
pub enum DilutedPoolInstanceDefError { #[error( "Dynamic layout log_diluted_units_per_step is out of range, absolute value must be < 32"
add the value to the error msg (same as it was before in RunnerError variant).
Code quote:
"Dynamic layout log_diluted_units_per_step is out of range, absolute value must be < 32"vm/src/vm/errors/runner_errors.rs line 125 at r2 (raw file):
BadDynamicLayoutBuiltinRatio(BuiltinName), #[error("dynamic layout log_diluted_units_per_step {0} is out of range, absolute value must be < 32")] DynamicLayoutLogDilutedUnitsPerStepOverflow(i32),
not needed anymore, right?
Code quote:
#[error("dynamic layout log_diluted_units_per_step {0} is out of range, absolute value must be < 32")]
DynamicLayoutLogDilutedUnitsPerStepOverflow(i32),a44f7b5 to
4d059c1
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 2 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on Yael-Starkware and YairVaknin-starkware).
vm/src/types/instance_definitions/diluted_pool_instance_def.rs line 7 at r2 (raw file):
Previously, YairVaknin-starkware wrote…
add the value to the error msg (same as it was before in
RunnerErrorvariant).
Done.
vm/src/vm/errors/runner_errors.rs line 125 at r2 (raw file):
Previously, YairVaknin-starkware wrote…
not needed anymore, right?
Done.
4d059c1 to
4103853
Compare
YairVaknin-starkware
left a comment
There was a problem hiding this comment.
@YairVaknin-starkware reviewed 4 files and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on Yael-Starkware).
Merge activity
|

TITLE
Description
Description of the pull request changes and motivation.
Checklist
This change is