feat: add disable_trace_padding field to Cairo1RunConfig#2364
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
8a44704 to
858b764
Compare
80a5973 to
8109d52
Compare
|
Benchmark Results for unmodified programs 🚀
|
8109d52 to
b619264
Compare
858b764 to
c71748f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 03-18-feat_refactor_cairorunner_ctors_to_accept_cairolayout_directly #2364 +/- ##
=====================================================================================================
Coverage 96.13% 96.13%
=====================================================================================================
Files 104 104
Lines 37498 37500 +2
=====================================================================================================
+ Hits 36047 36049 +2
Misses 1451 1451 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c71748f to
b3a7165
Compare
e9d44dc to
049360d
Compare
600cd1f to
274e737
Compare
049360d to
26cb69f
Compare
YairVaknin-starkware
left a comment
There was a problem hiding this comment.
@YairVaknin-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware and Yael-Starkware).
a discussion (no related file):
wdyt about avoiding this PR and just hardcoding false in the run_config() impl of Cairo1RunConfig (when introduced)? Seems cleaner to me.
274e737 to
788b4a7
Compare
26cb69f to
909b8f6
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
@dorimedini-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Yael-Starkware and YairVaknin-starkware).
a discussion (no related file):
Previously, YairVaknin-starkware wrote…
wdyt about avoiding this PR and just hardcoding false in the
run_config()impl ofCairo1RunConfig(when introduced)? Seems cleaner to me.
should it not be an option for Cairo1?

TITLE
Description
Description of the pull request changes and motivation.
Checklist
This change is