Skip to content

feat: add disable_trace_padding field to Cairo1RunConfig#2364

Open
dorimedini-starkware wants to merge 1 commit into03-18-feat_refactor_cairorunner_ctors_to_accept_cairolayout_directlyfrom
03-19-feat_add_disable_trace_padding_field_to_cairo1runconfig
Open

feat: add disable_trace_padding field to Cairo1RunConfig#2364
dorimedini-starkware wants to merge 1 commit into03-18-feat_refactor_cairorunner_ctors_to_accept_cairolayout_directlyfrom
03-19-feat_add_disable_trace_padding_field_to_cairo1runconfig

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware commented Mar 23, 2026

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

This change is Reviewable

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 23, 2026

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.121 ± 0.036 2.090 2.192 1.01 ± 0.02
head big_factorial 2.111 ± 0.031 2.094 2.195 1.00
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.028 ± 0.005 2.021 2.037 1.00
head big_fibonacci 2.034 ± 0.012 2.022 2.063 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.203 ± 0.178 7.108 7.675 1.01 ± 0.03
head blake2s_integration_benchmark 7.167 ± 0.060 7.081 7.297 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.163 ± 0.016 2.142 2.200 1.00 ± 0.01
head compare_arrays_200000 2.156 ± 0.010 2.145 2.181 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.415 ± 0.008 1.403 1.426 1.00
head dict_integration_benchmark 1.420 ± 0.007 1.410 1.432 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.207 ± 0.008 1.201 1.226 1.01 ± 0.01
head field_arithmetic_get_square_benchmark 1.200 ± 0.004 1.190 1.205 1.00
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.246 ± 0.028 7.197 7.287 1.00
head integration_builtins 7.259 ± 0.075 7.202 7.462 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.318 ± 0.014 7.301 7.338 1.00
head keccak_integration_benchmark 7.354 ± 0.053 7.301 7.468 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.144 ± 0.016 2.132 2.187 1.00
head linear_search 2.146 ± 0.006 2.133 2.152 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.490 ± 0.004 1.483 1.497 1.00 ± 0.00
head math_cmp_and_pow_integration_benchmark 1.487 ± 0.003 1.483 1.492 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.461 ± 0.006 1.454 1.473 1.01 ± 0.00
head math_integration_benchmark 1.453 ± 0.003 1.449 1.458 1.00
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.212 ± 0.009 1.206 1.236 1.00 ± 0.01
head memory_integration_benchmark 1.210 ± 0.004 1.206 1.217 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.530 ± 0.005 1.525 1.538 1.00
head operations_with_data_structures_benchmarks 1.540 ± 0.009 1.529 1.558 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 527.7 ± 1.9 525.7 530.0 1.00 ± 0.00
head pedersen 527.4 ± 1.1 525.9 529.4 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 607.4 ± 2.3 603.6 611.7 1.00 ± 0.00
head poseidon_integration_benchmark 607.4 ± 2.0 604.6 611.0 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.799 ± 0.005 1.792 1.809 1.00 ± 0.01
head secp_integration_benchmark 1.795 ± 0.008 1.782 1.806 1.00
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 630.6 ± 1.5 628.3 632.8 1.00 ± 0.01
head set_integration_benchmark 629.8 ± 2.8 627.1 635.7 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.172 ± 0.087 4.106 4.333 1.01 ± 0.02
head uint256_integration_benchmark 4.125 ± 0.011 4.106 4.138 1.00

@dorimedini-starkware dorimedini-starkware force-pushed the 03-19-feat_add_disable_trace_padding_field_to_cairo1runconfig branch from 8109d52 to b619264 Compare March 25, 2026 13:23
@dorimedini-starkware dorimedini-starkware force-pushed the 03-18-feat_refactor_cairorunner_ctors_to_accept_cairolayout_directly branch from 858b764 to c71748f Compare March 25, 2026 13:23
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.13%. Comparing base (274e737) to head (26cb69f).

Additional details and impacted files
@@                                          Coverage Diff                                          @@
##           03-18-feat_refactor_cairorunner_ctors_to_accept_cairolayout_directly    #2364   +/-   ##
=====================================================================================================
  Coverage                                                                 96.13%   96.13%           
=====================================================================================================
  Files                                                                       104      104           
  Lines                                                                     37498    37500    +2     
=====================================================================================================
+ Hits                                                                      36047    36049    +2     
  Misses                                                                     1451     1451           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dorimedini-starkware dorimedini-starkware force-pushed the 03-18-feat_refactor_cairorunner_ctors_to_accept_cairolayout_directly branch from c71748f to b3a7165 Compare March 25, 2026 13:37
@dorimedini-starkware dorimedini-starkware force-pushed the 03-19-feat_add_disable_trace_padding_field_to_cairo1runconfig branch 2 times, most recently from e9d44dc to 049360d Compare March 25, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 03-18-feat_refactor_cairorunner_ctors_to_accept_cairolayout_directly branch 2 times, most recently from 600cd1f to 274e737 Compare March 25, 2026 14:38
@dorimedini-starkware dorimedini-starkware force-pushed the 03-19-feat_add_disable_trace_padding_field_to_cairo1runconfig branch from 049360d to 26cb69f Compare March 25, 2026 14:38
Copy link
Copy Markdown
Collaborator

@YairVaknin-starkware YairVaknin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@YairVaknin-starkware reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on dorimedini-starkware and Yael-Starkware).


a discussion (no related file):
wdyt about avoiding this PR and just hardcoding false in the run_config() impl of Cairo1RunConfig (when introduced)? Seems cleaner to me.

@dorimedini-starkware dorimedini-starkware force-pushed the 03-18-feat_refactor_cairorunner_ctors_to_accept_cairolayout_directly branch from 274e737 to 788b4a7 Compare April 9, 2026 19:15
@dorimedini-starkware dorimedini-starkware force-pushed the 03-19-feat_add_disable_trace_padding_field_to_cairo1runconfig branch from 26cb69f to 909b8f6 Compare April 9, 2026 19:15
Copy link
Copy Markdown
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on Yael-Starkware and YairVaknin-starkware).


a discussion (no related file):

Previously, YairVaknin-starkware wrote…

wdyt about avoiding this PR and just hardcoding false in the run_config() impl of Cairo1RunConfig (when introduced)? Seems cleaner to me.

should it not be an option for Cairo1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants