Skip to content

feat: create and use CairoRunConfig as ctor arg for CairoRunner ctors#2367

Open
dorimedini-starkware wants to merge 1 commit into03-21-feat_move_runner_mode_to_be_a_field_in_stwocairorunconfigfrom
03-21-feat_create_and_use_cairorunconfig_as_ctor_arg_for_cairorunner_ctors
Open

feat: create and use CairoRunConfig as ctor arg for CairoRunner ctors#2367
dorimedini-starkware wants to merge 1 commit into03-21-feat_move_runner_mode_to_be_a_field_in_stwocairorunconfigfrom
03-21-feat_create_and_use_cairorunconfig_as_ctor_arg_for_cairorunner_ctors

Conversation

@dorimedini-starkware
Copy link
Copy Markdown
Collaborator

@dorimedini-starkware dorimedini-starkware commented Mar 23, 2026

TITLE

Description

Description of the pull request changes and motivation.

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.
    • CHANGELOG has been updated.

This change is Reviewable

@dorimedini-starkware dorimedini-starkware self-assigned this Mar 23, 2026
@dorimedini-starkware dorimedini-starkware marked this pull request as ready for review March 23, 2026 09:11
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_create_and_use_cairorunconfig_as_ctor_arg_for_cairorunner_ctors branch from 4fea4f5 to 6222559 Compare March 23, 2026 09:18
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_move_runner_mode_to_be_a_field_in_stwocairorunconfig branch from 9478b60 to 4853667 Compare March 23, 2026 09:18
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 23, 2026

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base big_factorial 2.121 ± 0.021 2.092 2.165 1.00
head big_factorial 2.128 ± 0.017 2.113 2.169 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base big_fibonacci 2.038 ± 0.011 2.023 2.053 1.00
head big_fibonacci 2.052 ± 0.009 2.041 2.067 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 7.153 ± 0.022 7.121 7.185 1.00
head blake2s_integration_benchmark 7.257 ± 0.055 7.210 7.399 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 2.164 ± 0.007 2.149 2.178 1.00
head compare_arrays_200000 2.182 ± 0.011 2.170 2.203 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 1.444 ± 0.013 1.427 1.464 1.00
head dict_integration_benchmark 1.448 ± 0.007 1.440 1.459 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base field_arithmetic_get_square_benchmark 1.212 ± 0.009 1.204 1.233 1.00
head field_arithmetic_get_square_benchmark 1.219 ± 0.010 1.211 1.245 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 7.296 ± 0.075 7.234 7.498 1.00
head integration_builtins 7.364 ± 0.051 7.318 7.458 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 7.332 ± 0.039 7.271 7.388 1.00
head keccak_integration_benchmark 7.457 ± 0.029 7.420 7.494 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search 2.145 ± 0.007 2.133 2.162 1.00
head linear_search 2.159 ± 0.010 2.147 2.175 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 1.493 ± 0.010 1.484 1.515 1.00
head math_cmp_and_pow_integration_benchmark 1.508 ± 0.006 1.498 1.517 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 1.459 ± 0.010 1.448 1.481 1.00
head math_integration_benchmark 1.487 ± 0.010 1.476 1.513 1.02 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 1.215 ± 0.006 1.208 1.226 1.00
head memory_integration_benchmark 1.219 ± 0.004 1.212 1.225 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 1.531 ± 0.003 1.524 1.536 1.00
head operations_with_data_structures_benchmarks 1.551 ± 0.007 1.542 1.569 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base pedersen 528.1 ± 1.8 526.0 532.7 1.00
head pedersen 529.7 ± 1.3 528.2 531.6 1.00 ± 0.00
Command Mean [ms] Min [ms] Max [ms] Relative
base poseidon_integration_benchmark 615.4 ± 10.6 605.0 633.7 1.01 ± 0.02
head poseidon_integration_benchmark 612.3 ± 5.0 608.6 625.3 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 1.801 ± 0.007 1.792 1.812 1.00
head secp_integration_benchmark 1.816 ± 0.007 1.807 1.827 1.01 ± 0.01
Command Mean [ms] Min [ms] Max [ms] Relative
base set_integration_benchmark 631.9 ± 1.6 630.0 635.4 1.00
head set_integration_benchmark 636.3 ± 2.7 633.2 643.2 1.01 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.174 ± 0.017 4.146 4.198 1.00
head uint256_integration_benchmark 4.215 ± 0.055 4.176 4.367 1.01 ± 0.01

@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_create_and_use_cairorunconfig_as_ctor_arg_for_cairorunner_ctors branch 6 times, most recently from 5ef6991 to 1c0aee2 Compare March 25, 2026 13:23
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_move_runner_mode_to_be_a_field_in_stwocairorunconfig branch from 4853667 to 8262ccd Compare March 25, 2026 13:23
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.19%. Comparing base (e15c441) to head (e1c6c51).

Additional details and impacted files
@@                                         Coverage Diff                                         @@
##           03-21-feat_move_runner_mode_to_be_a_field_in_stwocairorunconfig    #2367      +/-   ##
===================================================================================================
+ Coverage                                                            96.17%   96.19%   +0.01%     
===================================================================================================
  Files                                                                  105      105              
  Lines                                                                37770    37831      +61     
===================================================================================================
+ Hits                                                                 36326    36391      +65     
+ Misses                                                                1444     1440       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_create_and_use_cairorunconfig_as_ctor_arg_for_cairorunner_ctors branch from 1c0aee2 to e0b400b Compare March 25, 2026 13:37
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_move_runner_mode_to_be_a_field_in_stwocairorunconfig branch 2 times, most recently from 41e01a7 to 713a6ed Compare March 25, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_create_and_use_cairorunconfig_as_ctor_arg_for_cairorunner_ctors branch from e0b400b to 80ed22a Compare March 25, 2026 14:04
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_move_runner_mode_to_be_a_field_in_stwocairorunconfig branch from 713a6ed to cc4297e Compare March 25, 2026 14:38
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_create_and_use_cairorunconfig_as_ctor_arg_for_cairorunner_ctors branch from 80ed22a to 73efd57 Compare March 25, 2026 14:38
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_create_and_use_cairorunconfig_as_ctor_arg_for_cairorunner_ctors branch from 73efd57 to 5cb8404 Compare March 25, 2026 15:02
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_move_runner_mode_to_be_a_field_in_stwocairorunconfig branch from cc4297e to c1fa7b8 Compare March 25, 2026 15:02
Copy link
Copy Markdown
Collaborator

@YairVaknin-starkware YairVaknin-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@YairVaknin-starkware reviewed 15 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on Yael-Starkware).

@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_create_and_use_cairorunconfig_as_ctor_arg_for_cairorunner_ctors branch from 5cb8404 to 3212747 Compare April 9, 2026 19:15
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_move_runner_mode_to_be_a_field_in_stwocairorunconfig branch from c1fa7b8 to 3540366 Compare April 9, 2026 19:15
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_create_and_use_cairorunconfig_as_ctor_arg_for_cairorunner_ctors branch from 3212747 to 0de1656 Compare April 13, 2026 06:14
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_move_runner_mode_to_be_a_field_in_stwocairorunconfig branch 2 times, most recently from 3157b70 to e15c441 Compare April 13, 2026 06:54
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_create_and_use_cairorunconfig_as_ctor_arg_for_cairorunner_ctors branch from 0de1656 to 3fa2fba Compare April 13, 2026 06:54
@dorimedini-starkware dorimedini-starkware force-pushed the 03-21-feat_create_and_use_cairorunconfig_as_ctor_arg_for_cairorunner_ctors branch from 3fa2fba to e1c6c51 Compare April 13, 2026 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants