feat(daemon): add weave-SDK genai helper layer - #141
Merged
Conversation
This was referenced Jul 19, 2026
Contributor
Author
This was referenced Jul 19, 2026
HiveMind Sessions1 session · 47m · $48
View all sessions in HiveMind → Run |
rgao-coreweave
force-pushed
the
109-13-genai-helpers
branch
from
July 21, 2026 00:29
aff47b6 to
28f1c2a
Compare
Groundwork for swapping the daemon's hand-rolled span builders for the weave SDK genai primitives (next PRs in this stack): pure helpers typed against the SDK, consumed by nothing yet. - chatSpans.ts: response-key grouping (chatMessageKey, callsForResponseKey, findToolUseResponseKey) and chat-span open/record helpers (openChatForGroup, recordChat). - genaiSpans.ts: buildIntegrationAttrs, contentBlocksToParts, buildUsage, assistantOutputMessages; providerFromModel / jsonStr / parseTimestamp / snippet / toolDisplayName move into the kept helper section; the remaining builders are marked LEGACY (still used by daemon.ts until the swap lands). - parser.ts: isToolUseBlock type guard. - interleaved-assistant-spans.test.ts becomes a contentBlocksToParts unit test (its old child-span coverage returns rewritten with the swap). The old exporter and daemon behavior are untouched. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
rgao-coreweave
force-pushed
the
109-13-genai-helpers
branch
from
July 21, 2026 04:39
28f1c2a to
015c3ab
Compare
rgao-coreweave
marked this pull request as ready for review
July 21, 2026 06:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groundwork for swapping the daemon's hand-rolled span builders for the weave SDK genai primitives (next PRs in this stack): pure helpers typed against the SDK, consumed by nothing yet.
chatSpans.ts(new): response-key grouping and chat-span open/record helpers.genaiSpans.ts:buildIntegrationAttrs,contentBlocksToParts,buildUsage,assistantOutputMessages; existing formatting helpers move into the kept section; the remaining builders are marked LEGACY (still used bydaemon.tsuntil the swap lands).parser.ts:isToolUseBlocktype guard.interleaved-assistant-spans.test.tsbecomes acontentBlocksToPartsunit test.Old exporter and daemon behavior untouched.
npm run checkgreen (86 tests).