Skip to content

chore(daemon): remove dead manual OTel builders - #129

Merged
rgao-coreweave merged 1 commit into
mainfrom
109-08-delete-builders
Jul 23, 2026
Merged

chore(daemon): remove dead manual OTel builders#129
rgao-coreweave merged 1 commit into
mainfrom
109-08-delete-builders

Conversation

@rgao-coreweave

@rgao-coreweave rgao-coreweave commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Delete the legacy manual OpenTelemetry span builders.
  • Remove their unused direct dependencies and exports.
  • Keep the shared Weave initialization and attribute helpers used by later slices.

Review boundary

Deletion-only cleanup. This PR introduces no tracing lifecycle or correlation behavior.

Validation

  • npm run check
  • 60 tests pass at this stack point.

Stack

  1. chore(daemon): remove dead manual OTel builders #129 — remove dead span infrastructure
  2. refactor(parser): parse transcripts into turns and responses #130 — parse transcripts into turns and responses
  3. refactor(trace): separate daemon, hook, and session ownership #142 — trace root turns
  4. feat(trace): trace ordinary tool calls #147 — trace ordinary tools
  5. feat(trace): trace Agent lifecycles #131 — trace live Agent lifecycles
  6. fix(trace): recover Agent lifecycles (superseded by #131) #151 — recover Agent lifecycles
  7. feat(trace): trace permission decisions #148 — trace permission decisions
  8. fix(daemon): drain and finalize traces deterministically #149 — finalize deterministically
  9. feat(trace): trace explicit Agent Team lifecycles #143 — trace Agent Teams

@rgao-coreweave

Copy link
Copy Markdown
Contributor Author

Folded into #128 — the legacy span-builder deletion and OTLP-dependency removal now land in that PR, so this is redundant.

@github-actions github-actions Bot locked and limited conversation to collaborators Jul 18, 2026
@rgao-coreweave

Copy link
Copy Markdown
Contributor Author

Reopening: splitting #128 back into a stack for reviewability; this PR carries its original slice.

@rgao-coreweave
rgao-coreweave force-pushed the 109-08-delete-builders branch from 66ddbaf to 77395a7 Compare July 18, 2026 23:49
@rgao-coreweave
rgao-coreweave force-pushed the 109-08-delete-builders branch 2 times, most recently from 1c22d60 to 944c480 Compare July 21, 2026 06:30
@rgao-coreweave
rgao-coreweave force-pushed the 109-08-delete-builders branch from 944c480 to 936613c Compare July 21, 2026 06:39
@rgao-coreweave
rgao-coreweave force-pushed the 109-08-delete-builders branch from 936613c to 356d93c Compare July 21, 2026 17:07
@rgao-coreweave
rgao-coreweave force-pushed the 109-08-delete-builders branch 2 times, most recently from 1e2fb15 to 0f894fa Compare July 22, 2026 05:38
@rgao-coreweave
rgao-coreweave force-pushed the 109-08-delete-builders branch from 0f894fa to fba229f Compare July 22, 2026 17:12
@rgao-coreweave
rgao-coreweave force-pushed the 109-08-delete-builders branch from fba229f to 8be697f Compare July 22, 2026 17:26
@rgao-coreweave
rgao-coreweave force-pushed the 109-08-delete-builders branch from 8be697f to 9dc8439 Compare July 22, 2026 18:54
Delete the unused hand-rolled span builders, baggage plumbing, and builder-only attribute keys after the SDK migration. Keep @opentelemetry/api at runtime and move sdk-trace-base to development dependencies for the in-memory exporter tests.
@rgao-coreweave
rgao-coreweave force-pushed the 109-08-delete-builders branch from 9dc8439 to 1a1573c Compare July 22, 2026 23:45
@rgao-coreweave rgao-coreweave changed the title chore(daemon): delete the legacy span builders + old OTel deps chore(daemon): remove dead manual OTel builders Jul 22, 2026
@rgao-coreweave
rgao-coreweave changed the base branch from 109-15-subagent-spans to main July 22, 2026 23:47
@rgao-coreweave
rgao-coreweave marked this pull request as ready for review July 23, 2026 04:34
@rgao-coreweave
rgao-coreweave requested a review from a team as a code owner July 23, 2026 04:34

@drtangible drtangible left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 💯 💯

@rgao-coreweave
rgao-coreweave merged commit 3db1f62 into main Jul 23, 2026
3 checks passed
@wandb wandb unlocked this conversation Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants