refactor(setup): share the claude-plugin spawnSync plumbing - #123
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 17, 2026
rgao-coreweave
marked this pull request as ready for review
July 17, 2026 18:13
CLAUDE_SPAWN_OPTS + combinedOutput + failIfError replace the spawnSync options/error blocks repeated across the plugin registration calls. No behavior change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
rgao-coreweave
changed the base branch from
109-01-weave-deps
to
graphite-base/123
July 17, 2026 20:18
rgao-coreweave
force-pushed
the
graphite-base/123
branch
from
July 17, 2026 20:18
7154f1b to
c2aa3dd
Compare
rgao-coreweave
force-pushed
the
109-02-setup-spawn
branch
from
July 17, 2026 20:18
fd9d262 to
a954c3e
Compare
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dedupes the repeated
claude plugin ...spawnSync blocks in setup.ts. No behavior change.CLAUDE_SPAWN_OPTS: one shared options object (utf8, piped stdio).combinedOutput+failIfError: one implementation of the stderr+stdout join and the non-zero-exit throw/log, keeping the "already registered/installed" carve-out.Test plan:
npm run check(84 tests)🤖 Generated with Claude Code