refactor(config): extract shared config resolution - #124
Merged
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 17, 2026
rgao-coreweave
marked this pull request as ready for review
July 17, 2026 18:13
rgao-coreweave
force-pushed
the
109-02-setup-spawn
branch
from
July 17, 2026 20:18
fd9d262 to
a954c3e
Compare
rgao-coreweave
force-pushed
the
109-03-config-extract
branch
from
July 17, 2026 20:18
1a97da0 to
2761356
Compare
rgao-coreweave
changed the base branch from
109-02-setup-spawn
to
graphite-base/124
July 17, 2026 20:28
Move the env-over-settings resolvers (project/API key/agent name, from cli.ts) and resolveDaemonConfig/resolveTraceBaseUrl/fingerprint (from daemon.ts) into src/config.ts; dedupe the resolver twins via resolveFromEnvOrSettings and share missingConfig between status/restart and runDaemon. cmdConfig loses a let-reassign and a whole-object cast. Behavior note: an empty-string env var now falls through to settings instead of winning with a mislabeled source. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
rgao-coreweave
force-pushed
the
graphite-base/124
branch
from
July 17, 2026 20:34
a954c3e to
cc6dbff
Compare
rgao-coreweave
force-pushed
the
109-03-config-extract
branch
from
July 17, 2026 20:34
2761356 to
7693513
Compare
Contributor
Author
Merge activity
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New
src/config.tsshared by the CLI and daemon; resolution is defined once.resolveDaemonConfig,resolveTraceBaseUrl, and the fingerprint move from daemon.ts.resolveFromEnvOrSettings.missingConfigshared bystatus,restart, andrunDaemon(was three inline copies).Behavior note: an empty-string env var now falls through to settings instead of winning with a mislabeled source.
Test plan:
npm run check;status/config showoutput unchanged🤖 Generated with Claude Code