Skip to content

refactor(parser): parse transcripts into turns and responses - #130

Merged
rgao-coreweave merged 2 commits into
mainfrom
109-09-parser-fold
Jul 23, 2026
Merged

refactor(parser): parse transcripts into turns and responses#130
rgao-coreweave merged 2 commits into
mainfrom
109-09-parser-fold

Conversation

@rgao-coreweave

@rgao-coreweave rgao-coreweave commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Represent each assistant API response once and attach normalized responses to its turn.
  • Give reused response IDs occurrence-aware keys so nonconsecutive responses are not collapsed.
  • Centralize transcript-to-Weave response conversion and add parser regressions.

Review boundary

Transcript normalization only. Daemon lifecycle, tool, and Agent behavior come in later slices.

Validation

  • npm run check
  • 64 tests pass at this stack point.

Stack

  1. chore(daemon): remove dead manual OTel builders #129 — remove dead span infrastructure
  2. refactor(parser): parse transcripts into turns and responses #130 — parse transcripts into turns and responses
  3. refactor(trace): separate daemon, hook, and session ownership #142 — trace root turns
  4. feat(trace): trace ordinary tool calls #147 — trace ordinary tools
  5. feat(trace): trace Agent lifecycles #131 — trace live Agent lifecycles
  6. fix(trace): recover Agent lifecycles (superseded by #131) #151 — recover Agent lifecycles
  7. feat(trace): trace permission decisions #148 — trace permission decisions
  8. fix(daemon): drain and finalize traces deterministically #149 — finalize deterministically
  9. feat(trace): trace explicit Agent Team lifecycles #143 — trace Agent Teams

@rgao-coreweave

Copy link
Copy Markdown
Contributor Author

Folded into #128.

@github-actions github-actions Bot locked and limited conversation to collaborators Jul 18, 2026
@rgao-coreweave

Copy link
Copy Markdown
Contributor Author

Reopening: splitting #128 back into a stack for reviewability; this PR carries its original slice.

@rgao-coreweave
rgao-coreweave force-pushed the 109-09-parser-fold branch 2 times, most recently from 5d6957b to 4972dac Compare July 22, 2026 04:23
@rgao-coreweave
rgao-coreweave force-pushed the 109-09-parser-fold branch 2 times, most recently from 71fa9d1 to 36ec06f Compare July 22, 2026 17:26
@rgao-coreweave rgao-coreweave changed the title refactor(parser): one AssistantCallDetail per API response refactor(parser): normalize transcript responses Jul 22, 2026
@rgao-coreweave rgao-coreweave changed the title refactor(parser): normalize transcript responses refactor(parser): parse transcripts into turns and responses Jul 23, 2026
@rgao-coreweave
rgao-coreweave marked this pull request as ready for review July 23, 2026 05:30
@rgao-coreweave
rgao-coreweave requested a review from a team as a code owner July 23, 2026 05:30
Base automatically changed from 109-08-delete-builders to main July 23, 2026 16:24
@wandb wandb unlocked this conversation Jul 23, 2026

@drtangible drtangible left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍 👍

Comment thread src/parser.ts Outdated
Comment thread src/parser.ts Outdated
@rgao-coreweave
rgao-coreweave merged commit d02ce8f into main Jul 23, 2026
4 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Jul 23, 2026
@wandb wandb unlocked this conversation Jul 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants