refactor(daemon): move session types + tracking to sessionState.ts - #127
Merged
Merged
Conversation
This was referenced Jul 17, 2026
Contributor
Author
This was referenced Jul 17, 2026
Verbatim move of SessionState, the tracker types (PendingToolCall, SubagentTracker, TeamMember, LoadedInstruction), SubagentTracking, newSessionState, and resolvePermissionIfPending. Also dedupes the sha256-hex idiom into utils.sha256Hex now that it has two consumers (hashPrompt + the config fingerprint). No behavior change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
rgao-coreweave
force-pushed
the
109-06-session-types
branch
from
July 17, 2026 18:18
40c30a9 to
8747b24
Compare
rgao-coreweave
marked this pull request as ready for review
July 17, 2026 18:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verbatim move of
SessionState, the tracker types (PendingToolCall,SubagentTracker,TeamMember,LoadedInstruction),SubagentTracking,newSessionState, andresolvePermissionIfPendingout of daemon.ts.Also collapses the duplicated sha256-hex idiom into
utils.sha256Hex, now that both consumers exist (hashPromptfrom #126, the config fingerprint from #124).Purpose with #126: #128's diff on this file reads as a type swap (OTel
Spanfields to SDK handles), not an opaque new file.Test plan:
npm run check🤖 Generated with Claude Code