fix(daemon): drain and finalize traces deterministically - #149
Open
rgao-coreweave wants to merge 1 commit into
Open
fix(daemon): drain and finalize traces deterministically#149rgao-coreweave wants to merge 1 commit into
rgao-coreweave wants to merge 1 commit into
Conversation
This was referenced Jul 22, 2026
rgao-coreweave
force-pushed
the
109-13-deterministic-shutdown
branch
2 times, most recently
from
July 23, 2026 03:14
3583571 to
a85028b
Compare
This was referenced Jul 23, 2026
rgao-coreweave
force-pushed
the
109-13-deterministic-shutdown
branch
from
July 23, 2026 05:50
a85028b to
d0ed5d8
Compare
rgao-coreweave
force-pushed
the
109-13-deterministic-shutdown
branch
from
July 23, 2026 16:24
d0ed5d8 to
86166cd
Compare
rgao-coreweave
force-pushed
the
109-13-deterministic-shutdown
branch
from
July 23, 2026 22:46
86166cd to
250a87f
Compare
rgao-coreweave
force-pushed
the
109-13-deterministic-shutdown
branch
from
August 7, 2026 19:19
250a87f to
a1255d8
Compare
rgao-coreweave
force-pushed
the
109-13-deterministic-shutdown
branch
from
August 7, 2026 19:24
a1255d8 to
e08486b
Compare
rgao-coreweave
marked this pull request as ready for review
August 7, 2026 19:41
ro31337
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make daemon shutdown deterministic: stop socket admission, protect a successor socket inode, await queued hook work, finalize child spans before parent turns, flush Weave, and close transcripts. Signal handling also covers the startup window before socket binding completes.
Validation
npm run check