fix(scratchnode-v5): mobile visual reset (type scale + accent/mono discipline, cut first-viewport chrome)#499
Merged
Merged
Conversation
…scipline, cut first-viewport chrome Root cause was not "too many elements": :root had no type-size tokens (every component hardcoded sizes, so nothing ranked) and no accent/mono discipline (accent sprayed on logo/code/CTA/links; mono on human prose, not just IDs). Plus a flex-gap bug split the "ScratchNode" wordmark into "Scratch Node". - :root: add --fs-display/title/base/sub/label/mono type scale; reserve solid accent for the single primary action - header: fix wordmark flex-gap split; room code -> quiet muted mono chip; borderless menu icon - event strip: drop "0 FAQ"; gate L0 capture + event-mode to data-role=host (host/debug controls that leaked to attendees); de-mono to --ui - hero: drop duplicate joined count; "Disposable event brain" -> "Live event log - public wiki when it ends" (static + JS rewrite) - welcome banner: quiet (no accent card) + hidden on mobile - composer: placeholder -> "Message or /ask..." (fixes clipped placeholder, which came from JS not static markup); helpline 2 lines -> 1; privacy shows "Public" / "Private (lock)" text instead of an ambiguous open-lock glyph - empty state: remove giant "Ask the first question" CTA (composer is the CTA); "No messages yet" is the one 18px display element; copy teaches all 3 actions - keyboard: visualViewport --keyboard-offset pins the fixed composer above the keyboard; footer + welcome collapse while typing (data-input-focused) -> no more footer leaking behind the keyboard - menu: gate "Continue in NodeBench" to named users (was visible to anonymous guests under the hidden "Your notes" header); hide "Keyboard shortcuts" on mobile Presentational + copy only. Send/render path, seenIds dedup, and data-sn-live are untouched. Desktop layout unchanged (composer stays sticky-top). Verified: 49/49 chromium e2e (scratchnode-live-route-honesty 46 incl. home-v5-output-contract, + scratchnode-public-wiki 3); static launch scan PASS (0 blockers/warnings); before/after/keyboard/menu screenshots at 390px. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…t-clean # Conflicts: # CHANGELOG/pages/proto-home-v5.md
|
Demo: walkthrough of the surfaces this PR changed is available as a workflow artifact ( |
This was referenced Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ScratchNode v5 — mobile visual reset (one isolated commit on top of current
main)Single commit, 2 files (
public/proto/home-v5.html+ its changelog lane). Cherry-picked clean onto currentorigin/mainso it carries only the mobile reset — no scratchnode-line baggage, no wiki-CTA conflicts.Root cause (not "too many elements")
:roothad color/radius/motion tokens but no type scale — every component hardcoded its size, so nothing ranked.--accent/--monohad no discipline — accent sprayed on logo/code/CTA/links; mono on human prose, not just machine IDs..h-logo {flex; gap:6px}madeScratchand<span>Node</span>two flex items).Changes (presentational + copy only — send/render path, dedup,
data-sn-liveuntouched):root(--fs-display/title/base/sub/label/mono); one display size per screen; hero → 22px; empty-state title is the single 18px display element. Mono reserved for machine IDs (room code +/ask) — de-mono'd the strip, "LIVE ROOM" divider, menu headers, "Set name"..h-logo-word→ renders ScratchNode.●Eventmode +L0 Manualcapture (host/debug) todata-role="host"; de-mono'd.visualViewport→--keyboard-offsetpins the fixed composer above the keyboard; footer + welcome collapse while typing → no more footer leaking behind the keyboard.Hero merge note: kept
main's<h1>tag (a11y) and applied my type-scale + copy on top.Verification
scratchnode-live-route-honesty(incl.home-v5-output-contract) +scratchnode-public-wiki— main's canonical suite.Required CI (Typecheck / Runtime smoke / Build) gates this PR.
🤖 Generated with Claude Code