fix(frontend): resolve set-state-in-effect in ScanResultView (#1063)#1073
Open
ericsocrat wants to merge 1 commit intomainfrom
Open
fix(frontend): resolve set-state-in-effect in ScanResultView (#1063)#1073ericsocrat wants to merge 1 commit intomainfrom
ericsocrat wants to merge 1 commit intomainfrom
Conversation
Wraps two synchronous effect setState calls in requestAnimationFrame so they become asynchronous and no longer trip react-hooks/set-state-in-effect: the mount-time fade-in in FadeSlideIn, and the no-animation early return in the animated score count-up. Visual behaviour is unchanged. Both effects now also clean up the rAF on unmount.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📸 PR ScreenshotsCaptured 2 screenshots (1 mobile, 1 desktop) for 1 changed page(s):
📥 Download screenshots from workflow artifacts. Captured by PR Screenshots workflow • 2026-05-01 |
There was a problem hiding this comment.
Pull request overview
This PR addresses two remaining react-hooks/set-state-in-effect warnings in ScanResultView.tsx as part of the ongoing React Compiler lint-drain effort (#1063), while preserving the existing UI behavior (fade-in transition + score snap/count-up).
Changes:
- Updated
FadeSlideInto trigger its mount-time visibility flip viarequestAnimationFrame(and cancel on unmount). - Updated the “no animation” branch of the score count-up effect to set the final score via
requestAnimationFrame(and cancel on unmount).
Bundle Size Report
✅ Bundle size is within acceptable limits. |
This was referenced May 1, 2026
ericsocrat
added a commit
that referenced
this pull request
May 1, 2026
…) (#1077) Phase 2 of #1063 -- resolves 2 of 19 violations (running total: 12/19 across 9 PRs). Two react-hooks/set-state-in-effect warnings in SearchAutocomplete.tsx resolved by adjusting state during render: 1. Refresh recent-searches list on dropdown open: replaced the show-dep useEffect with a prevShow render-phase tracker. Added a lazy initial-state initializer so the list is hydrated on mount when show is already true (preserves existing test contract). 2. Reset activeIndex when suggestions/query change: replaced the multi-dep useEffect with a composite resetKey + prevResetKey render-phase tracker. Pattern: https://react.dev/learn/you-might-not-need-an-effect#adjusting-some-state-when-a-prop-changes Behaviour unchanged. 32/32 vitest pass, eslint and tsc clean. Cross-references: #1067, #1069, #1070, #1071, #1072, #1073, #1074, #1075, #1076. Co-authored-by: ericsocrat <ericsocrat@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 of #1063 — fifth of 19
react-hooks/set-state-in-effectviolations. Resolves two violations in a single file (lines 34 and 216).Change
Wraps two synchronous effect
setStatecalls inrequestAnimationFrameso they are asynchronous and no longer violate the rule:FadeSlideIn(line 34): mount-timesetVisible(true)to trigger the fade-in transition.prefersReducedortryVitScore === 0.Both effects now also
cancelAnimationFrameon unmount. Visual outcome is unchanged — the fade-in still runs from opacity 0 on the next frame, and the no-animation case still snaps the score to its target value.Verification
eslint src/components/scan/ScanResultView.tsx— cleanvitest run src/components/scan/ScanResultView.test.tsx— 33/33 passtsc --noEmit— cleanProgress