Skip to content

Restructure model posing and re-export AdvantageScope model#79

Merged
skrunked merged 14 commits into
devfrom
task/reexport-as-model
May 15, 2026
Merged

Restructure model posing and re-export AdvantageScope model#79
skrunked merged 14 commits into
devfrom
task/reexport-as-model

Conversation

@skrunked
Copy link
Copy Markdown
Contributor

@skrunked skrunked commented May 7, 2026

Created new file SunstoneV2Mechanism3D.java to store constants and getters related to component poses, and to log the robot's component poses. Also re-export CAD from Onshape to reflect new robot. Closes #70.

  • Tested in Sim
  • Tested on Robot (doesn't need to be)

…vantageScope model, remove the original ModelConstants, and restructure subsystems and Robot.javaaccordingly.
@skrunked skrunked linked an issue May 7, 2026 that may be closed by this pull request
22 tasks
@skrunked skrunked self-assigned this May 7, 2026
@skrunked
Copy link
Copy Markdown
Contributor Author

skrunked commented May 7, 2026

Mech3D file seems mostly good, currently re-exporting the CAD.

@skrunked skrunked marked this pull request as ready for review May 7, 2026 20:06
@skrunked
Copy link
Copy Markdown
Contributor Author

skrunked commented May 9, 2026

Angle of turret might be janked? Verify on Tuesday.

@skrunked skrunked requested a review from rxgran May 13, 2026 18:15
@skrunked skrunked assigned rxgran and unassigned skrunked May 13, 2026
Copy link
Copy Markdown
Contributor

@rxgran rxgran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really great commenting, minor things, possibly remove V1 model

@@ -0,0 +1,192 @@
{
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we really care about swapping back and forth between v1 and v2 models? Should we just have this be Sunstone and delete the old?

Copy link
Copy Markdown
Contributor Author

@skrunked skrunked May 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point, I'll remove the V1 model and rename the file accordingly. Especially since the pose information we're getting only works for V2.

Comment thread advantagescope/Robot_Sunstone/config.json
Comment thread src/main/java/org/team157/robot/subsystems/SunstoneMechanism3D.java
Comment thread src/main/java/org/team157/robot/subsystems/SunstoneMechanism3D.java
Comment thread src/main/java/org/team157/robot/subsystems/SunstoneMechanism3D.java
@rxgran rxgran assigned skrunked and unassigned rxgran May 15, 2026
@rxgran rxgran self-requested a review May 15, 2026 15:59
Copy link
Copy Markdown
Contributor

@rxgran rxgran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging please include a screenshot and/or video of the sim

Comment thread src/main/java/org/team157/robot/subsystems/SunstoneMechanism3D.java
@rxgran rxgran self-requested a review May 15, 2026 16:03
Copy link
Copy Markdown
Contributor

@rxgran rxgran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait also the build is failing on github actions? maybe check that first

@skrunked
Copy link
Copy Markdown
Contributor Author

Action now succeeds, I forgot to push some of the files.

8mb.video-JvX-BGSVR9CI.mp4

@skrunked skrunked requested a review from rxgran May 15, 2026 20:15
@skrunked skrunked assigned rxgran and unassigned skrunked May 15, 2026
Copy link
Copy Markdown
Contributor

@rxgran rxgran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gud

@skrunked skrunked merged commit 86616d1 into dev May 15, 2026
2 checks passed
@skrunked skrunked mentioned this pull request May 19, 2026
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] Update AdvantageScope model

2 participants