fix(frontend): resolve set-state-in-effect in useAnalytics (#1063)#1071
Open
ericsocrat wants to merge 1 commit intomainfrom
Open
fix(frontend): resolve set-state-in-effect in useAnalytics (#1063)#1071ericsocrat wants to merge 1 commit intomainfrom
ericsocrat wants to merge 1 commit intomainfrom
Conversation
deviceType is read only inside the fire-and-forget track() callback and never rendered, so it is more naturally a ref than state. Switching to a ref also makes the returned track() callback stable across renders.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Bundle Size Report
✅ Bundle size is within acceptable limits. |
There was a problem hiding this comment.
Pull request overview
Removes a react-hooks/set-state-in-effect lint violation in useAnalytics by avoiding state updates for values that are never rendered, keeping analytics tracking behavior the same while improving hook stability.
Changes:
- Replace
deviceTypestate with adeviceTypeRef, updating it on mount withoutsetState. - Make the returned
trackcallback stable across renders by removing thedeviceTypedependency. - Clean up React imports by dropping
useState.
This was referenced May 1, 2026
ericsocrat
added a commit
that referenced
this pull request
May 1, 2026
…) (#1077) Phase 2 of #1063 -- resolves 2 of 19 violations (running total: 12/19 across 9 PRs). Two react-hooks/set-state-in-effect warnings in SearchAutocomplete.tsx resolved by adjusting state during render: 1. Refresh recent-searches list on dropdown open: replaced the show-dep useEffect with a prevShow render-phase tracker. Added a lazy initial-state initializer so the list is hydrated on mount when show is already true (preserves existing test contract). 2. Reset activeIndex when suggestions/query change: replaced the multi-dep useEffect with a composite resetKey + prevResetKey render-phase tracker. Pattern: https://react.dev/learn/you-might-not-need-an-effect#adjusting-some-state-when-a-prop-changes Behaviour unchanged. 32/32 vitest pass, eslint and tsc clean. Cross-references: #1067, #1069, #1070, #1071, #1072, #1073, #1074, #1075, #1076. Co-authored-by: ericsocrat <ericsocrat@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 of #1063 — third of 19
react-hooks/set-state-in-effectviolations.Change
In
useAnalytics,deviceTypewas held in state but only read inside the fire-and-forgettrack()callback — it was never rendered. Switched to auseRefso the mount-only initialization no longer triggersreact-hooks/set-state-in-effect. Side benefit: the returnedtrackcallback is now stable across renders.Behaviour is unchanged: device type is still detected on mount via
detectDeviceType()and passed on every event.Verification
eslint src/hooks/use-analytics.ts— cleanvitest run src/hooks/use-analytics.test.tsx— 10/10 passtsc --noEmit— cleanProgress